Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CR287] Feature/issue 283 cluster codec artifact #290

Conversation

@artem-v
Copy link
Contributor

artem-v commented Jan 6, 2020

Motivation
Scalecube-cluster must work with default msg-codec or/and metadata-codec (default meaning no additional dependency settings in client pom, no mandatory programmatic settings).
While at the same time it must be possible to specify msg-codec/metadata-codec programmatically or add dependency section in the pom, and those must override default (obviously).

Changes

  • Made sclecube-cluster dto classes implement Externalizable (btw, with Serializable it would work also).
  • left dependency on scalecube-codec-jackson only in examples module.
  • enhanced validateConfiguration() function.
@eutkin
eutkin approved these changes Jan 6, 2020
@artem-v artem-v merged commit f5c4505 into feature/issue-283-cluster-codec-artifact Jan 6, 2020
2 of 3 checks passed
2 of 3 checks passed
Codacy/PR Quality Review Codacy was unable to analyse your pull request.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@artem-v artem-v deleted the feature/issue-283-cluster-codec-artifact-CR2arvy branch Jan 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.