Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

Rotation Issues #3

Closed
akaspick opened this Issue · 2 comments

2 participants

@akaspick

The Toast view doesn't appear to work well when the device orientation is changed. If the Toast view is centered for example and while it's being displayed, the device is rotated, the Toast view doesn't remain centered.

@scalessec scalessec closed this
@scalessec
Owner

Views created with makeViewForMessage:title:image: and makeToastActivity: will have the autoresizing mask set with flexible left, right, top, & bottom to handle rotation correctly. Toast will respect whatever autoresizing mask is set on custom views displayed as Toast.

@akaspick

Works, thanks.

@datalogics-kam datalogics-kam referenced this issue from a commit in datalogics-kam/Toast
@datalogics-kam datalogics-kam Merge commit 'bde0500' into DLReader2
This duplicates the old commit titled "Merge branch 'vendor-toast' into
open-books-with-joined-accounts"

Changes from the original merge attempt:

- Kept the vendor usage of #pragma mark
- Left in the testing of objc_arc before calling autorelease.
- Autoresizing mask left on wrapperView
- Shadow code for wrapper view retained; our tweaks turn it off anyway
  by setting kDisplayShadow to NO.
- Kept as close to vendor spacing usage as possible. (Use git diff -w to
  see differences in spacing).

These changes were kept to prevent future merge conflicts with the
upstream.

* commit 'bde0500':
  Adding shared scheme
  Issue #4: Adding ARC support for Toast and demo project
  Removing userdata from the project file
  Example explicitly sets autoresizing mask on custom Toast view
  Issue #3: setting autoresizing mask on toast views to fix rotation issues
  Editing readme again
  Editing readme
  Adding basic support for activity views
  Added a define to turn shadow on/off at compile time. Enabled by default.
  Added a shadow to the toast
  updating readme
  switching floats to CGFloats
  Formatting improvements
  Improved code formatting
  Updated the project settings to use LLVM

Conflicts:
	Toast/classes/toast/Toast+UIView.m
fee0432
@datalogics-kam datalogics-kam referenced this issue from a commit in datalogics-kam/Toast
@datalogics-kam datalogics-kam Merge commit 'bde0500' into from-current-dlreader
This duplicates the old commit titled "Merge branch 'vendor-toast' into
open-books-with-joined-accounts"

Changes from the original merge attempt:

- Kept the vendor usage of #pragma mark
- Left in the testing of objc_arc before calling autorelease.
- Autoresizing mask left on wrapperView
- Shadow code for wrapper view retained; our tweaks turn it off anyway
  by setting kDisplayShadow to NO.
- Kept as close to vendor spacing usage as possible. (Use git diff -w to
  see differences in spacing).

These changes were kept to prevent future merge conflicts with the
upstream.

* commit 'bde0500':
  Adding shared scheme
  Issue #4: Adding ARC support for Toast and demo project
  Removing userdata from the project file
  Example explicitly sets autoresizing mask on custom Toast view
  Issue #3: setting autoresizing mask on toast views to fix rotation issues
  Editing readme again
  Editing readme
  Adding basic support for activity views
  Added a define to turn shadow on/off at compile time. Enabled by default.
  Added a shadow to the toast
  updating readme
  switching floats to CGFloats
  Formatting improvements
  Improved code formatting
  Updated the project settings to use LLVM

Conflicts:
	Toast/classes/toast/Toast+UIView.m
7c325d1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.