From ccfd73a730115f312cc13e9420fe7bd57b57dfb4 Mon Sep 17 00:00:00 2001 From: thomas-tacquet Date: Fri, 4 Oct 2024 16:03:23 +0200 Subject: [PATCH 1/2] feat(containers): details on port variable --- serverless/containers/concepts.mdx | 4 ++-- .../deploy-a-container-from-external-container-registry.mdx | 4 +--- .../containers/reference-content/containers-limitations.mdx | 2 +- 3 files changed, 4 insertions(+), 6 deletions(-) diff --git a/serverless/containers/concepts.mdx b/serverless/containers/concepts.mdx index 9c13102c52..f59a9ed48a 100644 --- a/serverless/containers/concepts.mdx +++ b/serverless/containers/concepts.mdx @@ -71,7 +71,7 @@ The container can then process the message and perform any required actions, suc The port parameter specifies the network port that your container listens on for incoming requests. If your application or container is set up to listen on a different port, you must specify it using the port parameter when deploying your container to Serverless Containers. It must reflect the port configuration within your container for your service to function correctly. -When creating your container image, we recommend configuring it to listen to the `$PORT` variable. The value defined in the port parameter will then be passed to your container during the deployment. +The value defined in the port parameter will then be passed to your container during the deployment inside the `PORT` environment variable. ## Privacy policy @@ -129,4 +129,4 @@ Unit used to measure the resource consumption of a container. It reflects the am ## Protocol -Serverless Containers supports **http1** (default) and **http2** (`h2c`). In some cases, for example, while deploying a container using gRPC, you may need to upgrade the protocol for it to work. \ No newline at end of file +Serverless Containers supports **http1** (default) and **http2** (`h2c`). In some cases, for example, while deploying a container using gRPC, you may need to upgrade the protocol for it to work. diff --git a/serverless/containers/how-to/deploy-a-container-from-external-container-registry.mdx b/serverless/containers/how-to/deploy-a-container-from-external-container-registry.mdx index 5ea746b1ed..c27e4e33d0 100644 --- a/serverless/containers/how-to/deploy-a-container-from-external-container-registry.mdx +++ b/serverless/containers/how-to/deploy-a-container-from-external-container-registry.mdx @@ -39,7 +39,7 @@ For now, Serverless Containers only supports public images. - Choose a **name** for your container and, optionally, a **description**. The name must only contain alphanumeric characters and dashes. - Choose the **resources** to be allocated to your container at runtime. These define the performance characteristics of your container. - Available memory depends on allocated VCPU, and maximum ephemeral storage value depends on allocated memory. + Available memory depends on allocated vCPU, and maximum ephemeral storage value depends on allocated memory. - Set your [scaling](/serverless/containers/concepts/#scaling) preferences, or leave them at default values. The Scaleway platform autoscales the number of available instances of your container to match the incoming load, depending on the settings you define here. - Click **Advanced options** to define any [environment variables](/serverless/containers/concepts/#environment-variables) you want to inject into your container. For each environment variable, click **+Add variable** and enter the key/value pair. @@ -48,5 +48,3 @@ For now, Serverless Containers only supports public images. - Set a custom [timeout](/serverless/containers/concepts/#timeout) for your container. - Verify the **estimated cost**. 5. Click **Deploy container** to finish. - - diff --git a/serverless/containers/reference-content/containers-limitations.mdx b/serverless/containers/reference-content/containers-limitations.mdx index 257cb9e872..862cf2402d 100644 --- a/serverless/containers/reference-content/containers-limitations.mdx +++ b/serverless/containers/reference-content/containers-limitations.mdx @@ -64,7 +64,7 @@ In order to ensure the proper functioning of the product, we restrict the use of * 9090 * 9091 * Reserved environment variables: - * `PORT`: Port on which your server should listen to (the default value is 8080) + * `PORT`: Value of the port definied in Container settings which the container has to listen to. You can use this environment variable inside your Container for easier deployments to define. * `SCW_*`: Reserved for product configuration (for example: token validation) ## Default values for CPU and memory limits From a4c3ff9302f03b84a922d0c6fa09abd93fe926a2 Mon Sep 17 00:00:00 2001 From: Thomas TACQUET Date: Mon, 7 Oct 2024 16:51:23 +0200 Subject: [PATCH 2/2] Apply suggestions from code review Co-authored-by: SamyOubouaziz --- .../containers/reference-content/containers-limitations.mdx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/serverless/containers/reference-content/containers-limitations.mdx b/serverless/containers/reference-content/containers-limitations.mdx index 862cf2402d..64ad8c4a73 100644 --- a/serverless/containers/reference-content/containers-limitations.mdx +++ b/serverless/containers/reference-content/containers-limitations.mdx @@ -64,7 +64,7 @@ In order to ensure the proper functioning of the product, we restrict the use of * 9090 * 9091 * Reserved environment variables: - * `PORT`: Value of the port definied in Container settings which the container has to listen to. You can use this environment variable inside your Container for easier deployments to define. + * `PORT`: Value of the port defined in the Container settings, which the container has to listen on. You can use this environment variable inside your Container for easier deployments. * `SCW_*`: Reserved for product configuration (for example: token validation) ## Default values for CPU and memory limits