Use Domain ID when fetching the device list from netshot #10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When syncing between netbox and netshot, we already need to pass the netshot_domain_id. Newly added devices are added in that domain.
However, when fetching the list in netshot, so we know what devices to disable, we don't use that domain_id, so we will disable all devices instead of just the ones we are trying to sync.
I have a usecase with two groups of devices in netbox, that have a different device role (customers, backbone). Each role goes into it's own domain in netshot. The current code will disable all devices from the customer domain, when I sync the backbone domain and visa versa.
Example commands to sync both groups:
This MR fixes this, by fetching only the devices that we are actually trying to sync.
As a small bonus, I fixed two typo's.