Add a short (ttl-based) cache to AccountAPI.get_quotas()
#24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to optimize usecases like this :
=> we check several quotas of the same organization in a very short period of time, typically within less than 1sec
In that usecase, the current AccountAPI does 3 calls to API-account, which is sub-optimal.
But we can easily cache "in-ram" the response to
get_quotas()
, because it's getting all quotas of a given organization, and re-use it for the 2nd and 3rd call.NB: currently, each call to api-account to get quotas takes ~60 ms, so each call avoided is a lot :)