Skip to content

Conversation

@moul
Copy link
Contributor

@moul moul commented Aug 6, 2015

What I have done:

  • moved the main.go file in the ./cmd/scw/ folder
  • moved all the packes (api, scwversion, utils, commands) in the ./pkg/ folder
  • split the commands code between 2 packages:
    • cli: command-line parsing, usage, help, and exit codes
    • commands: actions without notion of command-line interface, everything is run in a context (own stdin,stdout,stderr), no exits

We will now be able to chain and write unit tests for the commands


Done:

  • global project structure
  • command help
  • command attach
  • command commit
  • command cp
  • command create
  • command events
  • command exec
  • command history
  • command images
  • command info
  • command inspect
  • command kill
  • command login
  • command logout
  • command logs
  • command port
  • command ps
  • command rename
  • command restart
  • command rm
  • command rmi
  • command run
  • command search
  • command start
  • command stop
  • command tag
  • command top
  • command version
  • command wait

@moul moul force-pushed the fix-80-refactor branch 2 times, most recently from 8d996b1 to 9630de1 Compare August 6, 2015 16:27
@moul moul force-pushed the fix-80-refactor branch from 9630de1 to 91617d1 Compare August 6, 2015 16:29
@QuentinPerez
Copy link
Contributor

LGTM 👍 Good work 😊

QuentinPerez pushed a commit that referenced this pull request Aug 7, 2015
@QuentinPerez QuentinPerez merged commit 746946c into scaleway:master Aug 7, 2015
@moul moul deleted the fix-80-refactor branch August 7, 2015 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants