From c1b3bd0abeae779ecae0273468f03337be090fc5 Mon Sep 17 00:00:00 2001 From: Quentin Perez Date: Mon, 24 Oct 2016 18:38:17 +0200 Subject: [PATCH 1/2] fix: ps --filter --- pkg/commands/ps.go | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/pkg/commands/ps.go b/pkg/commands/ps.go index 11759d7aa3..449f348876 100644 --- a/pkg/commands/ps.go +++ b/pkg/commands/ps.go @@ -53,8 +53,7 @@ func RunPs(ctx CommandContext, args PsArgs) error { logrus.Warnf("Unknown filter: '%s=%s'", key, value) } } - filtered := make([]api.ScalewayServer, len(*servers)) - index := 0 + filtered := make([]api.ScalewayServer, 0, len(*servers)) for _, server := range *servers { // filtering for key, value := range args.Filters { @@ -100,8 +99,7 @@ func RunPs(ctx CommandContext, args PsArgs) error { } } } - filtered[index] = server - index++ + filtered = append(filtered, server) skipServer: continue } From 0d4fd272f725cdb4976e2da5f9be964ba7116f29 Mon Sep 17 00:00:00 2001 From: Quentin Perez Date: Mon, 24 Oct 2016 18:40:07 +0200 Subject: [PATCH 2/2] README: update --- README.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/README.md b/README.md index 6d9e6862c2..5126de7b30 100644 --- a/README.md +++ b/README.md @@ -1201,6 +1201,10 @@ $ scw inspect myserver | jq '.[0].public_ip.address' ## Changelog +### master (unreleased) + +* `scw ps` do not display empty server with --filter + ### v1.10.1 (2016-10-24) * `scw login` fix CheckCredentials ([418](https://github.com/scaleway/scaleway-cli/issues/418))