Skip to content

fix(telemetry): disable telemetry on completion #684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2020
Merged

fix(telemetry): disable telemetry on completion #684

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions internal/core/build_info_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,8 @@ import (
)

var fakeCommand = &Command{
Namespace: "plop",
DisableTelemetry: true,
ArgsType: reflect.TypeOf(args.RawArgs{}),
Namespace: "plop",
ArgsType: reflect.TypeOf(args.RawArgs{}),
Run: func(ctx context.Context, argsI interface{}) (i interface{}, e error) {
return &SuccessResult{}, nil
},
Expand Down
32 changes: 18 additions & 14 deletions internal/namespaces/autocomplete/autocomplete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -236,9 +236,10 @@ func autocompleteCompleteBashCommand() *core.Command {
Resource: "complete",
Verb: "bash",
// TODO: Switch NoClient to true when cache will be implemented.
NoClient: false,
Hidden: true,
ArgsType: reflect.TypeOf(args.RawArgs{}),
NoClient: false,
Hidden: true,
DisableTelemetry: true,
ArgsType: reflect.TypeOf(args.RawArgs{}),
Run: func(ctx context.Context, argsI interface{}) (i interface{}, e error) {
rawArgs := *argsI.(*args.RawArgs)
wordIndex, err := strconv.Atoi(rawArgs[1])
Expand Down Expand Up @@ -273,9 +274,10 @@ func autocompleteCompleteFishCommand() *core.Command {
Resource: "complete",
Verb: "fish",
// TODO: Switch NoClient to true when cache will be implemented.
NoClient: false,
Hidden: true,
ArgsType: reflect.TypeOf(args.RawArgs{}),
NoClient: false,
Hidden: true,
DisableTelemetry: true,
ArgsType: reflect.TypeOf(args.RawArgs{}),
Run: func(ctx context.Context, argsI interface{}) (i interface{}, e error) {
rawArgs := *argsI.(*args.RawArgs)
leftWords := rawArgs[3:]
Expand Down Expand Up @@ -304,9 +306,10 @@ func autocompleteCompleteZshCommand() *core.Command {
Resource: "complete",
Verb: "zsh",
// TODO: Switch NoClient to true when cache will be implemented.
NoClient: false,
Hidden: true,
ArgsType: reflect.TypeOf(args.RawArgs{}),
NoClient: false,
Hidden: true,
DisableTelemetry: true,
ArgsType: reflect.TypeOf(args.RawArgs{}),
Run: func(ctx context.Context, argsI interface{}) (i interface{}, e error) {
rawArgs := *argsI.(*args.RawArgs)

Expand Down Expand Up @@ -343,11 +346,12 @@ type autocompleteShowArgs struct {

func autocompleteScriptCommand() *core.Command {
return &core.Command{
Short: `Show autocomplete script for current shell`,
Long: `Show autocomplete script for current shell.`,
Namespace: "autocomplete",
Resource: "script",
NoClient: true,
Short: `Show autocomplete script for current shell`,
Long: `Show autocomplete script for current shell.`,
Namespace: "autocomplete",
Resource: "script",
NoClient: true,
DisableTelemetry: true,
ArgSpecs: core.ArgSpecs{
{
Name: "shell",
Expand Down