From 59b43b5ee7215a4b14459f703af67e011763d41a Mon Sep 17 00:00:00 2001 From: Emmanuel Chambon Date: Wed, 14 Dec 2022 18:52:04 +0100 Subject: [PATCH 1/4] chore: prepare for shared tsconfig --- .../use-dataloader/src/__tests__/DataLoaderProvider.test.tsx | 2 +- packages/use-segment/src/__tests__/index.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx b/packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx index 83088abc5..133d5950e 100644 --- a/packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx +++ b/packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx @@ -129,7 +129,7 @@ describe('DataLoaderProvider', () => { expect(result.current.getRequest(TEST_KEY)).toBeDefined() const unknownReload = result.current.getReloads('unknown') expect(unknownReload).toBeUndefined() - await reloads.test() + await reloads?.test() expect(method).toBeCalledTimes(3) await result.current.reloadAll() expect(method).toBeCalledTimes(4) diff --git a/packages/use-segment/src/__tests__/index.tsx b/packages/use-segment/src/__tests__/index.tsx index 3d97e9170..e14b1bd3b 100644 --- a/packages/use-segment/src/__tests__/index.tsx +++ b/packages/use-segment/src/__tests__/index.tsx @@ -11,7 +11,7 @@ const eventError = new Error('Error Event') const defaultEvents = { errorEvent: (_?: Analytics, onEventError?: OnEventError) => async () => { try { - await new Promise((resolve, reject) => { + await new Promise((__, reject) => { reject(eventError) }) } catch (error) { From d3f5f6a03fa79005dd5a0870a8271c4af0d69255 Mon Sep 17 00:00:00 2001 From: Emmanuel Chambon Date: Wed, 14 Dec 2022 18:54:05 +0100 Subject: [PATCH 2/4] fix: proper --- .../use-dataloader/src/__tests__/DataLoaderProvider.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx b/packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx index 133d5950e..369093d1c 100644 --- a/packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx +++ b/packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx @@ -129,7 +129,7 @@ describe('DataLoaderProvider', () => { expect(result.current.getRequest(TEST_KEY)).toBeDefined() const unknownReload = result.current.getReloads('unknown') expect(unknownReload).toBeUndefined() - await reloads?.test() + await reloads?.['test']?.() expect(method).toBeCalledTimes(3) await result.current.reloadAll() expect(method).toBeCalledTimes(4) From 88bd70e4ea27f19bfeed59acdaeaf1a029c6f002 Mon Sep 17 00:00:00 2001 From: Emmanuel Chambon Date: Wed, 14 Dec 2022 18:54:18 +0100 Subject: [PATCH 3/4] fix: proper --- .../use-dataloader/src/__tests__/DataLoaderProvider.test.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx b/packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx index 369093d1c..15013e06d 100644 --- a/packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx +++ b/packages/use-dataloader/src/__tests__/DataLoaderProvider.test.tsx @@ -129,7 +129,7 @@ describe('DataLoaderProvider', () => { expect(result.current.getRequest(TEST_KEY)).toBeDefined() const unknownReload = result.current.getReloads('unknown') expect(unknownReload).toBeUndefined() - await reloads?.['test']?.() + await reloads?.['test']() expect(method).toBeCalledTimes(3) await result.current.reloadAll() expect(method).toBeCalledTimes(4) From ea10047bae4a237fdb483c7f8037450de22bd3bb Mon Sep 17 00:00:00 2001 From: Emmanuel Chambon Date: Thu, 15 Dec 2022 11:41:54 +0100 Subject: [PATCH 4/4] fix: update --- tsconfig.json | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tsconfig.json b/tsconfig.json index 21833cd8b..84accc045 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -10,7 +10,8 @@ "esModuleInterop": true, "allowSyntheticDefaultImports": true, "resolveJsonModule": true, - "jsx": "preserve" + "jsx": "preserve", + "noPropertyAccessFromIndexSignature": true }, "include": ["**/*.ts", "**/*.js", "**/.*.js", "**/*.tsx"], "exclude": [