From 84b6d912af5270c43317cdb92b99d674dc9795a4 Mon Sep 17 00:00:00 2001 From: Vincent Germain Date: Tue, 17 Oct 2023 10:24:47 +0200 Subject: [PATCH 1/2] test(cookies): cover edge cases --- .../useSegmentIntegrations/working.tsx | 22 +++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/packages/cookie-consent/src/CookieConsentProvider/__tests__/useSegmentIntegrations/working.tsx b/packages/cookie-consent/src/CookieConsentProvider/__tests__/useSegmentIntegrations/working.tsx index e07a5a541..74e54d080 100644 --- a/packages/cookie-consent/src/CookieConsentProvider/__tests__/useSegmentIntegrations/working.tsx +++ b/packages/cookie-consent/src/CookieConsentProvider/__tests__/useSegmentIntegrations/working.tsx @@ -38,6 +38,20 @@ globalThis.fetch = jest.fn(() => website: 'http://google-ta.com', category: 'Unknown Category', }, + { + name: 'Google Ads (Gtag)', + creationName: 'Google AdWords New', + description: `Advertise on Google and put your message in front of potential customers right when they're searching for what you have to offer.`, + website: 'https://adwords.google.com', + category: 'Advertising', + }, + { + name: 'Amplitude (Actions)', + creationName: 'Actions Amplitude', + description: `Amplitude is an event tracking and segmentation platform for your web and mobile apps. By analyzing the actions your users perform, you can gain a better understanding to drive retention, engagement, and conversion.`, + website: 'https://amplitude.com', + category: 'Analytics', + }, ]), }), ) @@ -72,6 +86,14 @@ describe('CookieConsent - useSegmentIntegrations', () => { category: 'marketing', name: 'Scaleway Custom', }, + { + category: 'marketing', + name: 'Google AdWords New', + }, + { + category: 'analytics', + name: 'Amplitude (Actions)', + }, ]) }) From 103ee170302d5b8af98a0e84eb78688e12cf9c3c Mon Sep 17 00:00:00 2001 From: Vincent Germain Date: Tue, 17 Oct 2023 12:01:26 +0200 Subject: [PATCH 2/2] chore: changeset --- .changeset/mean-sheep-clean.md | 5 +++++ 1 file changed, 5 insertions(+) create mode 100644 .changeset/mean-sheep-clean.md diff --git a/.changeset/mean-sheep-clean.md b/.changeset/mean-sheep-clean.md new file mode 100644 index 000000000..865e006da --- /dev/null +++ b/.changeset/mean-sheep-clean.md @@ -0,0 +1,5 @@ +--- +'@scaleway/cookie-consent': patch +--- + +cover more edge cases for cookie tests