From 5d7ec7b0c319756dd544d1a62986ad3ba495b003 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Lafont?= Date: Thu, 28 Dec 2023 09:52:29 +0100 Subject: [PATCH 1/2] feat(eslint-config-react): add jsx-key rule --- .changeset/shiny-waves-remain.md | 5 +++++ packages/eslint-config-react/shared.js | 1 + 2 files changed, 6 insertions(+) create mode 100644 .changeset/shiny-waves-remain.md diff --git a/.changeset/shiny-waves-remain.md b/.changeset/shiny-waves-remain.md new file mode 100644 index 000000000..d282cb5da --- /dev/null +++ b/.changeset/shiny-waves-remain.md @@ -0,0 +1,5 @@ +--- +'@scaleway/eslint-config-react': minor +--- + +Add react/jsx-key rule diff --git a/packages/eslint-config-react/shared.js b/packages/eslint-config-react/shared.js index f7b42818b..e6b724242 100644 --- a/packages/eslint-config-react/shared.js +++ b/packages/eslint-config-react/shared.js @@ -123,5 +123,6 @@ module.exports = { ], 'sort-keys': 'off', 'no-constant-binary-expression': 'error', + 'react/jsx-key': 'error', }, } From fe969af1d2742963eb6370ebbb4b25c93d5128fb Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Cl=C3=A9ment=20Lafont?= Date: Thu, 28 Dec 2023 10:07:39 +0100 Subject: [PATCH 2/2] fix: disable jsx-key rule for tests --- .eslintrc | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.eslintrc b/.eslintrc index 4c15ea56e..3687048a3 100644 --- a/.eslintrc +++ b/.eslintrc @@ -38,7 +38,8 @@ "**/__tests__/**/*.ts{x,}" ], "rules": { - "import/no-extraneous-dependencies": "off" + "import/no-extraneous-dependencies": "off", + "react/jsx-key": "off" } } ]