From 37f5752e3bb4ba5f8d0999a4535ee120830ff2e3 Mon Sep 17 00:00:00 2001 From: Emmanuel Chambon Date: Fri, 12 Feb 2021 18:50:02 +0100 Subject: [PATCH 1/4] feat(eslint): enable not yet enabled react plugin rules from airbnb --- packages/eslint-config-react/index.js | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/packages/eslint-config-react/index.js b/packages/eslint-config-react/index.js index 4aa882f7f..efa906bc0 100644 --- a/packages/eslint-config-react/index.js +++ b/packages/eslint-config-react/index.js @@ -1,5 +1,5 @@ module.exports = { - extends: ['airbnb', 'airbnb/base', 'prettier', 'prettier/react'], + extends: ['airbnb', 'airbnb/hooks', 'prettier', 'prettier/react'], parser: '@babel/eslint-parser', env: { browser: true, @@ -26,5 +26,9 @@ module.exports = { ], 'react/jsx-filename-extension': ['error', { extensions: ['.js'] }], + 'react/jsx-no-script-url': 'error', + 'react/jsx-no-useless-fragment': 'error', + 'react/no-adjacent-inline-elements': 'error', + 'react/jsx-no-constructed-context-values': 'warn' }, } From d21c082cd41587baca9d4332585d63f44f69140d Mon Sep 17 00:00:00 2001 From: Emmanuel Chambon Date: Fri, 12 Feb 2021 18:54:05 +0100 Subject: [PATCH 2/4] fix: remove useless plugin --- packages/eslint-config-react/index.js | 1 - 1 file changed, 1 deletion(-) diff --git a/packages/eslint-config-react/index.js b/packages/eslint-config-react/index.js index efa906bc0..e2d18c993 100644 --- a/packages/eslint-config-react/index.js +++ b/packages/eslint-config-react/index.js @@ -5,7 +5,6 @@ module.exports = { browser: true, jest: true, }, - plugins: ['react-hooks'], rules: { 'import/order': [ 'error', From 7f64ca590233569977f62f3e2466ace63c129b9e Mon Sep 17 00:00:00 2001 From: Emmanuel Chambon Date: Fri, 12 Feb 2021 18:54:52 +0100 Subject: [PATCH 3/4] feat: add common rule --- packages/eslint-config-react/index.js | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/packages/eslint-config-react/index.js b/packages/eslint-config-react/index.js index e2d18c993..51997ba37 100644 --- a/packages/eslint-config-react/index.js +++ b/packages/eslint-config-react/index.js @@ -6,6 +6,14 @@ module.exports = { jest: true, }, rules: { + 'sort-imports': [ + 'error', + { + ignoreDeclarationSort: true, + memberSyntaxSortOrder: ['single', 'multiple', 'all', 'none'], + }, + ], + 'import/order': [ 'error', { From 5f4cab3cf3fa301809673c7e43d033cb923561a7 Mon Sep 17 00:00:00 2001 From: Emmanuel Chambon Date: Fri, 12 Feb 2021 18:58:53 +0100 Subject: [PATCH 4/4] fix: correct lint --- packages/regex/src/__tests__/index.js | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/regex/src/__tests__/index.js b/packages/regex/src/__tests__/index.js index 10fdbd2a0..93bd3800e 100644 --- a/packages/regex/src/__tests__/index.js +++ b/packages/regex/src/__tests__/index.js @@ -1,6 +1,10 @@ import { alpha, alphanum, + alphanumLowercase, + alphanumSpacesDotsUnderscoreDash, + alphanumUnderscoreDash, + alphanumUnderscoreDollarDash, alphanumdash, alphanumdashdots, alphanumdashdotsorempty, @@ -8,10 +12,6 @@ import { alphanumdashorempty, alphanumdashspaces, alphanumdots, - alphanumLowercase, - alphanumSpacesDotsUnderscoreDash, - alphanumUnderscoreDash, - alphanumUnderscoreDollarDash, ascii, backupKey, cron, @@ -19,8 +19,8 @@ import { email, fourDigitsCode, phone, - spaces, sixDigitsCode, + spaces, url, } from '..'