From 9686f11e91f368bbb8fee7f5ea631282e0e30ac9 Mon Sep 17 00:00:00 2001
From: Emmanuel Chambon <echambon@scaleway.com>
Date: Mon, 9 Aug 2021 21:37:55 +0200
Subject: [PATCH 1/2] feat(eslint-config-react): enable for..of syntax + enable
 react/no-unstable-nested-components

---
 packages/eslint-config-react/shared.js | 41 +++++++++++++++++++++++---
 1 file changed, 37 insertions(+), 4 deletions(-)

diff --git a/packages/eslint-config-react/shared.js b/packages/eslint-config-react/shared.js
index 79330c201..7b4608543 100644
--- a/packages/eslint-config-react/shared.js
+++ b/packages/eslint-config-react/shared.js
@@ -2,6 +2,7 @@ module.exports = {
   extends: ['airbnb/hooks', 'prettier'],
   rules: {
     'import/order': [
+      // https://github.com/import-js/eslint-plugin-import/blob/master/docs/rules/order.md
       'error',
       {
         alphabetize: {
@@ -18,7 +19,31 @@ module.exports = {
         'newlines-between': 'never',
       },
     ],
+    // This allows us to reenable ForOfStatement.
+    // While this has been disabled in airbnb configuration it's native to the browsers we support
+    // so the original argument about weight is no up to date https://github.com/airbnb/javascript/issues/1271
+    'no-restricted-syntax': [
+      // https://eslint.org/docs/rules/no-restricted-syntax#disallow-specified-syntax-no-restricted-syntax
+      'error',
+      {
+        message:
+          'for..in loops iterate over the entire prototype chain, which is virtually never what you want. Use Object.{keys,values,entries}, and iterate over the resulting array.',
+        selector: 'ForInStatement',
+      },
+      {
+        message:
+          'Labels are a form of GOTO; using them makes code confusing and hard to maintain and understand.',
+        selector: 'LabeledStatement',
+      },
+      {
+        message:
+          '`with` is disallowed in strict mode because it makes code impossible to predict and optimize.',
+        selector: 'WithStatement',
+      },
+    ],
+    // This is to have a more breathable codebase
     'padding-line-between-statements': [
+      // https://eslint.org/docs/rules/padding-line-between-statements
       'error',
       {
         blankLine: 'always',
@@ -26,15 +51,23 @@ module.exports = {
         prev: '*',
       },
     ],
-    'react/jsx-no-constructed-context-values': 'warn',
-    'react/jsx-no-script-url': 'error',
-    'react/jsx-no-useless-fragment': 'error',
-    'react/no-adjacent-inline-elements': 'error',
+    // These are rules soon to be enabled by airbnb react config
+    // We're getting a head start
+    'react/jsx-no-constructed-context-values': 'warn', // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-constructed-context-values.md
+    'react/jsx-no-script-url': 'error', // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-script-url.md
+    'react/jsx-no-useless-fragment': 'error', // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-useless-fragment.md
+    'react/no-adjacent-inline-elements': 'error', // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-adjacent-inline-elements.md
+    'react/no-unstable-nested-components': 'warn', // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unstable-nested-components.md
+
+    // To have consistent ordering in proptypes
     'react/sort-prop-types': [
+      // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/sort-prop-types.md
       'error',
       { ignoreCase: true, requiredFirst: false, sortShapeProp: true },
     ],
+    // Same but for imports
     'sort-imports': [
+      // https://eslint.org/docs/rules/sort-imports
       'error',
       {
         ignoreDeclarationSort: true,

From fec2c29c9dd470dffc3158d1294f0e73162ae729 Mon Sep 17 00:00:00 2001
From: Emmanuel Chambon <echambon@scaleway.com>
Date: Mon, 9 Aug 2021 21:41:07 +0200
Subject: [PATCH 2/2] chore: enable react/no-unstable-nested-components

---
 packages/eslint-config-react/shared.js | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/packages/eslint-config-react/shared.js b/packages/eslint-config-react/shared.js
index 7b4608543..04baf4baf 100644
--- a/packages/eslint-config-react/shared.js
+++ b/packages/eslint-config-react/shared.js
@@ -57,7 +57,7 @@ module.exports = {
     'react/jsx-no-script-url': 'error', // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-script-url.md
     'react/jsx-no-useless-fragment': 'error', // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/jsx-no-useless-fragment.md
     'react/no-adjacent-inline-elements': 'error', // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-adjacent-inline-elements.md
-    'react/no-unstable-nested-components': 'warn', // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unstable-nested-components.md
+    'react/no-unstable-nested-components': 'error', // https://github.com/yannickcr/eslint-plugin-react/blob/master/docs/rules/no-unstable-nested-components.md
 
     // To have consistent ordering in proptypes
     'react/sort-prop-types': [