From 8045f550f59b31d3f2a335327db59fc9e3b812b4 Mon Sep 17 00:00:00 2001 From: "dependabot[bot]" <49699333+dependabot[bot]@users.noreply.github.com> Date: Thu, 26 Aug 2021 21:07:23 +0000 Subject: [PATCH 1/2] chore(deps-dev): bump typescript from 4.3.5 to 4.4.2 Bumps [typescript](https://github.com/Microsoft/TypeScript) from 4.3.5 to 4.4.2. - [Release notes](https://github.com/Microsoft/TypeScript/releases) - [Commits](https://github.com/Microsoft/TypeScript/commits) --- updated-dependencies: - dependency-name: typescript dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] --- yarn.lock | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/yarn.lock b/yarn.lock index c31e30e5a..a0b1cd230 100644 --- a/yarn.lock +++ b/yarn.lock @@ -8506,9 +8506,9 @@ typedarray@^0.0.6: integrity sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c= typescript@^4.3.5: - version "4.3.5" - resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.3.5.tgz#4d1c37cc16e893973c45a06886b7113234f119f4" - integrity sha512-DqQgihaQ9cUrskJo9kIyW/+g0Vxsk8cDtZ52a3NGh0YNTfpUSArXSohyUGnvbPazEPLu398C0UxmKSOrPumUzA== + version "4.4.2" + resolved "https://registry.yarnpkg.com/typescript/-/typescript-4.4.2.tgz#6d618640d430e3569a1dfb44f7d7e600ced3ee86" + integrity sha512-gzP+t5W4hdy4c+68bfcv0t400HVJMMd2+H9B7gae1nQlBzCqvrXX+6GL/b3GAgyTH966pzrZ70/fRjwAtZksSQ== uglify-js@^3.1.4: version "3.13.5" From 0342ad40ce687cf62fa4cde3584a686397b31cd0 Mon Sep 17 00:00:00 2001 From: Emmanuel Chambon Date: Fri, 27 Aug 2021 09:25:38 +0200 Subject: [PATCH 2/2] fix: correct Error handling according to typescript upgrade --- packages/use-dataloader/src/useDataLoader.ts | 4 ++-- tsconfig.json | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/packages/use-dataloader/src/useDataLoader.ts b/packages/use-dataloader/src/useDataLoader.ts index c16a4c771..b66eb880d 100644 --- a/packages/use-dataloader/src/useDataLoader.ts +++ b/packages/use-dataloader/src/useDataLoader.ts @@ -129,8 +129,8 @@ const useDataLoader = ( await onSuccess?.(result) } catch (err) { - dispatch(Actions.createOnError(err)) - await ((onError ?? onErrorProvider)?.(err)) + dispatch(Actions.createOnError(err as Error)) + await ((onError ?? onErrorProvider)?.(err as Error)) } }, [ diff --git a/tsconfig.json b/tsconfig.json index 097ccc386..c2d5f3ea9 100644 --- a/tsconfig.json +++ b/tsconfig.json @@ -1,5 +1,6 @@ { "compilerOptions": { + "noEmit": true, "target": "esnext", "lib": [ "DOM",