From 5b59367cbc18a09532a046ff164d48b11e8cd1d6 Mon Sep 17 00:00:00 2001 From: Renovate Bot Date: Fri, 25 Mar 2022 08:40:08 +0000 Subject: [PATCH 1/3] fix(deps): update typescript-eslint monorepo to v5.16.0 --- packages/eslint-config-react/package.json | 4 +- pnpm-lock.yaml | 80 +++++++++++------------ 2 files changed, 42 insertions(+), 42 deletions(-) diff --git a/packages/eslint-config-react/package.json b/packages/eslint-config-react/package.json index 3915c3797..f1ef68a7e 100644 --- a/packages/eslint-config-react/package.json +++ b/packages/eslint-config-react/package.json @@ -17,8 +17,8 @@ }, "license": "MIT", "dependencies": { - "@typescript-eslint/eslint-plugin": "5.12.1", - "@typescript-eslint/parser": "5.12.1", + "@typescript-eslint/eslint-plugin": "5.16.0", + "@typescript-eslint/parser": "5.16.0", "eslint-config-airbnb": "19.0.4", "eslint-config-airbnb-typescript": "16.2.0", "eslint-config-prettier": "8.5.0", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index be054c94c..35d84e76e 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -75,8 +75,8 @@ importers: packages/eslint-config-react: specifiers: - '@typescript-eslint/eslint-plugin': 5.12.1 - '@typescript-eslint/parser': 5.12.1 + '@typescript-eslint/eslint-plugin': 5.16.0 + '@typescript-eslint/parser': 5.16.0 eslint-config-airbnb: 19.0.4 eslint-config-airbnb-typescript: 16.2.0 eslint-config-prettier: 8.5.0 @@ -86,10 +86,10 @@ importers: eslint-plugin-react: 7.29.4 eslint-plugin-react-hooks: 4.4.0 dependencies: - '@typescript-eslint/eslint-plugin': 5.12.1_f8c59ce224ac86f07606d7f8949a6f79 - '@typescript-eslint/parser': 5.12.1_eslint@8.12.0+typescript@4.6.3 + '@typescript-eslint/eslint-plugin': 5.16.0_4df62b6e125e6f18efee2d013b4a9d80 + '@typescript-eslint/parser': 5.16.0_eslint@8.12.0+typescript@4.6.3 eslint-config-airbnb: 19.0.4_0e8add1558a5db1c8c27993badaaf9fd - eslint-config-airbnb-typescript: 16.2.0_a29858e2bba45725ca029d2d72e376f3 + eslint-config-airbnb-typescript: 16.2.0_189e287bec36b88455bae52d0e4ab876 eslint-config-prettier: 8.5.0_eslint@8.12.0 eslint-plugin-eslint-comments: 3.2.0_eslint@8.12.0 eslint-plugin-import: 2.25.4_eslint@8.12.0 @@ -4186,8 +4186,8 @@ packages: '@types/yargs-parser': 21.0.0 dev: true - /@typescript-eslint/eslint-plugin/5.12.1_f8c59ce224ac86f07606d7f8949a6f79: - resolution: {integrity: sha512-M499lqa8rnNK7mUv74lSFFttuUsubIRdAbHcVaP93oFcKkEmHmLqy2n7jM9C8DVmFMYK61ExrZU6dLYhQZmUpw==} + /@typescript-eslint/eslint-plugin/5.16.0_4df62b6e125e6f18efee2d013b4a9d80: + resolution: {integrity: sha512-SJoba1edXvQRMmNI505Uo4XmGbxCK9ARQpkvOd00anxzri9RNQk0DDCxD+LIl+jYhkzOJiOMMKYEHnHEODjdCw==} engines: {node: ^12.22.0 || ^14.17.0 || >=16.0.0} peerDependencies: '@typescript-eslint/parser': ^5.0.0 @@ -4197,10 +4197,10 @@ packages: typescript: optional: true dependencies: - '@typescript-eslint/parser': 5.12.1_eslint@8.12.0+typescript@4.6.3 - '@typescript-eslint/scope-manager': 5.12.1 - '@typescript-eslint/type-utils': 5.12.1_eslint@8.12.0+typescript@4.6.3 - '@typescript-eslint/utils': 5.12.1_eslint@8.12.0+typescript@4.6.3 + '@typescript-eslint/parser': 5.16.0_eslint@8.12.0+typescript@4.6.3 + '@typescript-eslint/scope-manager': 5.16.0 + '@typescript-eslint/type-utils': 5.16.0_eslint@8.12.0+typescript@4.6.3 + '@typescript-eslint/utils': 5.16.0_eslint@8.12.0+typescript@4.6.3 debug: 4.3.3 eslint: 8.12.0 functional-red-black-tree: 1.0.1 @@ -4213,8 +4213,8 @@ packages: - supports-color dev: false - /@typescript-eslint/parser/5.12.1_eslint@8.12.0+typescript@4.6.3: - resolution: {integrity: sha512-6LuVUbe7oSdHxUWoX/m40Ni8gsZMKCi31rlawBHt7VtW15iHzjbpj2WLiToG2758KjtCCiLRKZqfrOdl3cNKuw==} + /@typescript-eslint/parser/5.16.0_eslint@8.12.0+typescript@4.6.3: + resolution: {integrity: sha512-fkDq86F0zl8FicnJtdXakFs4lnuebH6ZADDw6CYQv0UZeIjHvmEw87m9/29nk2Dv5Lmdp0zQ3zDQhiMWQf/GbA==} engines: {node: ^12.22.0 || ^14.17.0 || >=16.0.0} peerDependencies: eslint: ^6.0.0 || ^7.0.0 || ^8.0.0 @@ -4223,9 +4223,9 @@ packages: typescript: optional: true dependencies: - '@typescript-eslint/scope-manager': 5.12.1 - '@typescript-eslint/types': 5.12.1 - '@typescript-eslint/typescript-estree': 5.12.1_typescript@4.6.3 + '@typescript-eslint/scope-manager': 5.16.0 + '@typescript-eslint/types': 5.16.0 + '@typescript-eslint/typescript-estree': 5.16.0_typescript@4.6.3 debug: 4.3.3 eslint: 8.12.0 typescript: 4.6.3 @@ -4233,16 +4233,16 @@ packages: - supports-color dev: false - /@typescript-eslint/scope-manager/5.12.1: - resolution: {integrity: sha512-J0Wrh5xS6XNkd4TkOosxdpObzlYfXjAFIm9QxYLCPOcHVv1FyyFCPom66uIh8uBr0sZCrtS+n19tzufhwab8ZQ==} + /@typescript-eslint/scope-manager/5.16.0: + resolution: {integrity: sha512-P+Yab2Hovg8NekLIR/mOElCDPyGgFZKhGoZA901Yax6WR6HVeGLbsqJkZ+Cvk5nts/dAlFKm8PfL43UZnWdpIQ==} engines: {node: ^12.22.0 || ^14.17.0 || >=16.0.0} dependencies: - '@typescript-eslint/types': 5.12.1 - '@typescript-eslint/visitor-keys': 5.12.1 + '@typescript-eslint/types': 5.16.0 + '@typescript-eslint/visitor-keys': 5.16.0 dev: false - /@typescript-eslint/type-utils/5.12.1_eslint@8.12.0+typescript@4.6.3: - resolution: {integrity: sha512-Gh8feEhsNLeCz6aYqynh61Vsdy+tiNNkQtc+bN3IvQvRqHkXGUhYkUi+ePKzP0Mb42se7FDb+y2SypTbpbR/Sg==} + /@typescript-eslint/type-utils/5.16.0_eslint@8.12.0+typescript@4.6.3: + resolution: {integrity: sha512-SKygICv54CCRl1Vq5ewwQUJV/8padIWvPgCxlWPGO/OgQLCijY9G7lDu6H+mqfQtbzDNlVjzVWQmeqbLMBLEwQ==} engines: {node: ^12.22.0 || ^14.17.0 || >=16.0.0} peerDependencies: eslint: '*' @@ -4251,7 +4251,7 @@ packages: typescript: optional: true dependencies: - '@typescript-eslint/utils': 5.12.1_eslint@8.12.0+typescript@4.6.3 + '@typescript-eslint/utils': 5.16.0_eslint@8.12.0+typescript@4.6.3 debug: 4.3.3 eslint: 8.12.0 tsutils: 3.21.0_typescript@4.6.3 @@ -4260,13 +4260,13 @@ packages: - supports-color dev: false - /@typescript-eslint/types/5.12.1: - resolution: {integrity: sha512-hfcbq4qVOHV1YRdhkDldhV9NpmmAu2vp6wuFODL71Y0Ixak+FLeEU4rnPxgmZMnGreGEghlEucs9UZn5KOfHJA==} + /@typescript-eslint/types/5.16.0: + resolution: {integrity: sha512-oUorOwLj/3/3p/HFwrp6m/J2VfbLC8gjW5X3awpQJ/bSG+YRGFS4dpsvtQ8T2VNveV+LflQHjlLvB6v0R87z4g==} engines: {node: ^12.22.0 || ^14.17.0 || >=16.0.0} dev: false - /@typescript-eslint/typescript-estree/5.12.1_typescript@4.6.3: - resolution: {integrity: sha512-ahOdkIY9Mgbza7L9sIi205Pe1inCkZWAHE1TV1bpxlU4RZNPtXaDZfiiFWcL9jdxvW1hDYZJXrFm+vlMkXRbBw==} + /@typescript-eslint/typescript-estree/5.16.0_typescript@4.6.3: + resolution: {integrity: sha512-SE4VfbLWUZl9MR+ngLSARptUv2E8brY0luCdgmUevU6arZRY/KxYoLI/3V/yxaURR8tLRN7bmZtJdgmzLHI6pQ==} engines: {node: ^12.22.0 || ^14.17.0 || >=16.0.0} peerDependencies: typescript: '*' @@ -4274,8 +4274,8 @@ packages: typescript: optional: true dependencies: - '@typescript-eslint/types': 5.12.1 - '@typescript-eslint/visitor-keys': 5.12.1 + '@typescript-eslint/types': 5.16.0 + '@typescript-eslint/visitor-keys': 5.16.0 debug: 4.3.3 globby: 11.1.0 is-glob: 4.0.3 @@ -4286,16 +4286,16 @@ packages: - supports-color dev: false - /@typescript-eslint/utils/5.12.1_eslint@8.12.0+typescript@4.6.3: - resolution: {integrity: sha512-Qq9FIuU0EVEsi8fS6pG+uurbhNTtoYr4fq8tKjBupsK5Bgbk2I32UGm0Sh+WOyjOPgo/5URbxxSNV6HYsxV4MQ==} + /@typescript-eslint/utils/5.16.0_eslint@8.12.0+typescript@4.6.3: + resolution: {integrity: sha512-iYej2ER6AwmejLWMWzJIHy3nPJeGDuCqf8Jnb+jAQVoPpmWzwQOfa9hWVB8GIQE5gsCv/rfN4T+AYb/V06WseQ==} engines: {node: ^12.22.0 || ^14.17.0 || >=16.0.0} peerDependencies: eslint: ^6.0.0 || ^7.0.0 || ^8.0.0 dependencies: '@types/json-schema': 7.0.9 - '@typescript-eslint/scope-manager': 5.12.1 - '@typescript-eslint/types': 5.12.1 - '@typescript-eslint/typescript-estree': 5.12.1_typescript@4.6.3 + '@typescript-eslint/scope-manager': 5.16.0 + '@typescript-eslint/types': 5.16.0 + '@typescript-eslint/typescript-estree': 5.16.0_typescript@4.6.3 eslint: 8.12.0 eslint-scope: 5.1.1 eslint-utils: 3.0.0_eslint@8.12.0 @@ -4304,11 +4304,11 @@ packages: - typescript dev: false - /@typescript-eslint/visitor-keys/5.12.1: - resolution: {integrity: sha512-l1KSLfupuwrXx6wc0AuOmC7Ko5g14ZOQ86wJJqRbdLbXLK02pK/DPiDDqCc7BqqiiA04/eAA6ayL0bgOrAkH7A==} + /@typescript-eslint/visitor-keys/5.16.0: + resolution: {integrity: sha512-jqxO8msp5vZDhikTwq9ubyMHqZ67UIvawohr4qF3KhlpL7gzSjOd+8471H3nh5LyABkaI85laEKKU8SnGUK5/g==} engines: {node: ^12.22.0 || ^14.17.0 || >=16.0.0} dependencies: - '@typescript-eslint/types': 5.12.1 + '@typescript-eslint/types': 5.16.0 eslint-visitor-keys: 3.3.0 dev: false @@ -5638,7 +5638,7 @@ packages: semver: 6.3.0 dev: false - /eslint-config-airbnb-typescript/16.2.0_a29858e2bba45725ca029d2d72e376f3: + /eslint-config-airbnb-typescript/16.2.0_189e287bec36b88455bae52d0e4ab876: resolution: {integrity: sha512-OUaMPZpTOZGKd5tXOjJ9PRU4iYNW/Z5DoHIynjsVK/FpkWdiY5+nxQW6TiJAlLwVI1l53xUOrnlZWtVBVQzuWA==} peerDependencies: '@typescript-eslint/eslint-plugin': ^5.0.0 @@ -5646,8 +5646,8 @@ packages: eslint: ^7.32.0 || ^8.2.0 eslint-plugin-import: ^2.25.3 dependencies: - '@typescript-eslint/eslint-plugin': 5.12.1_f8c59ce224ac86f07606d7f8949a6f79 - '@typescript-eslint/parser': 5.12.1_eslint@8.12.0+typescript@4.6.3 + '@typescript-eslint/eslint-plugin': 5.16.0_4df62b6e125e6f18efee2d013b4a9d80 + '@typescript-eslint/parser': 5.16.0_eslint@8.12.0+typescript@4.6.3 eslint: 8.12.0 eslint-config-airbnb-base: 15.0.0_dae71b730d6620b67a20047a747b2eda eslint-plugin-import: 2.25.4_eslint@8.12.0 From 29bf7e20ad34355f2f001a591a027a0ac537111d Mon Sep 17 00:00:00 2001 From: Tom Date: Fri, 25 Mar 2022 09:13:59 +0000 Subject: [PATCH 2/3] fix: lint error --- packages/use-dataloader/src/useDataLoader.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/use-dataloader/src/useDataLoader.ts b/packages/use-dataloader/src/useDataLoader.ts index 4688b4df7..a511d6fc0 100644 --- a/packages/use-dataloader/src/useDataLoader.ts +++ b/packages/use-dataloader/src/useDataLoader.ts @@ -82,7 +82,7 @@ const useDataLoader = ( } }, [onSuccess, onError, onErrorProvider, method, request]) - const cancelMethodRef = useRef<(() => void) | undefined>(request?.cancel) + const cancelMethodRef = useRef<(() => Promise) | undefined>(request?.cancel) const isLoading = useMemo( () => @@ -141,7 +141,7 @@ const useDataLoader = ( return () => { isMountedRef.current = false if (isFetchingRef.current && cancelMethodRef.current) { - cancelMethodRef.current() + cancelMethodRef.current().catch(undefined) } unsubscribeRequestRef.current?.() } From 424da40ada89b74b4678aa7e30b0b306da6bc28b Mon Sep 17 00:00:00 2001 From: Emmanuel Chambon Date: Tue, 5 Apr 2022 15:54:22 +0200 Subject: [PATCH 3/3] fix: ignore error instead of swallowing --- packages/use-dataloader/src/useDataLoader.ts | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/packages/use-dataloader/src/useDataLoader.ts b/packages/use-dataloader/src/useDataLoader.ts index a511d6fc0..0ca8e4287 100644 --- a/packages/use-dataloader/src/useDataLoader.ts +++ b/packages/use-dataloader/src/useDataLoader.ts @@ -141,7 +141,8 @@ const useDataLoader = ( return () => { isMountedRef.current = false if (isFetchingRef.current && cancelMethodRef.current) { - cancelMethodRef.current().catch(undefined) + // eslint-disable-next-line @typescript-eslint/no-floating-promises + cancelMethodRef.current() } unsubscribeRequestRef.current?.() }