Skip to content

feat(object): add object lock configuration resource #1566

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 32 commits into from
Nov 10, 2022
Merged

feat(object): add object lock configuration resource #1566

merged 32 commits into from
Nov 10, 2022

Conversation

@quantumsheep
Copy link
Member

@quantumsheep quantumsheep commented Nov 2, 2022 •
edited
Loading

Resolves #1467.

@quantumsheep quantumsheep added the object Object storage issues, bugs and feature requests label Nov 2, 2022
@quantumsheep quantumsheep self-assigned this Nov 2, 2022
@quantumsheep quantumsheep linked an issue Nov 2, 2022 that may be closed by this pull request
Resource Object Storage: Setting up object lock #1467
Closed
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022 •
edited
Loading

Codecov Report

Merging #1566 (0704c1f) into master (90ff9ad) will decrease coverage by 0.36%.
The diff coverage is 34.16%.

@@            Coverage Diff             @@
##           master    #1566      +/-   ##
==========================================
- Coverage   67.55%   67.18%   -0.37%     
==========================================
  Files         139      140       +1     
  Lines       22433    22662     +229     
==========================================
+ Hits        15154    15225      +71     
- Misses       5973     6131     +158     
  Partials     1306     1306
Impacted Files Coverage Δ
...leway/resource_object_bucket_lock_configuration.go 28.78% <28.78%> (ø)
scaleway/resource_object_bucket.go 79.83% <64.70%> (-1.30%) ⬇️
scaleway/provider.go 71.82% <100.00%> (+0.09%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Monitob
Monitob suggested changes Nov 4, 2022
View reviewed changes
@quantumsheep quantumsheep requested a review from Monitob November 4, 2022 13:31
@quantumsheep quantumsheep marked this pull request as ready for review November 4, 2022 13:31
Monitob
Monitob reviewed Nov 4, 2022
View reviewed changes
remyleone
remyleone reviewed Nov 4, 2022
View reviewed changes
Monitob
Monitob reviewed Nov 4, 2022
View reviewed changes
@quantumsheep quantumsheep requested a review from Monitob November 7, 2022 10:32
Codelax
Codelax reviewed Nov 10, 2022
View reviewed changes
Codelax
Codelax reviewed Nov 10, 2022
View reviewed changes
@Codelax Codelax self-requested a review November 10, 2022 15:58
Codelax
Codelax previously approved these changes Nov 10, 2022
View reviewed changes
Monitob
Monitob suggested changes Nov 10, 2022
View reviewed changes
Monitob
Monitob reviewed Nov 10, 2022
View reviewed changes
@quantumsheep quantumsheep merged commit 53ac552 into master Nov 10, 2022
@quantumsheep quantumsheep deleted the feat/object-lock branch November 10, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@remyleone remyleone Awaiting requested review from remyleone remyleone is a code owner

@Codelax Codelax Awaiting requested review from Codelax

1 more reviewer

@Monitob Monitob Monitob approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@quantumsheep quantumsheep

Labels

enhancement object Object storage issues, bugs and feature requests

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Resource Object Storage: Setting up object lock

6 participants

@quantumsheep @codecov-commenter @remyleone @Monitob @Codelax