From bcc82102059efd35b042f312ba6cb4c4a668e2f8 Mon Sep 17 00:00:00 2001
From: Jules Casteran <jcasteran@scaleway.com>
Date: Tue, 21 May 2024 14:34:22 +0200
Subject: [PATCH 1/2] docs: add examples

---
 .gitignore                             |  5 +++++
 examples/instance-servers/README.md    |  3 +++
 examples/instance-servers/main.tf      | 18 ++++++++++++++++++
 examples/instance-servers/outputs.tf   |  3 +++
 examples/instance-servers/variables.tf |  4 ++++
 5 files changed, 33 insertions(+)
 create mode 100644 examples/instance-servers/README.md
 create mode 100644 examples/instance-servers/main.tf
 create mode 100644 examples/instance-servers/outputs.tf
 create mode 100644 examples/instance-servers/variables.tf

diff --git a/.gitignore b/.gitignore
index 5623a1c6b..330001808 100644
--- a/.gitignore
+++ b/.gitignore
@@ -26,6 +26,11 @@ test.tf
 *.test
 *.iml
 .vscode
+.terraform.tfstate.lock.info
+.terraform.lock.hcl
+
+# generated for examples tests
+examples/**/provider.tf
 
 website/vendor
 
diff --git a/examples/instance-servers/README.md b/examples/instance-servers/README.md
new file mode 100644
index 000000000..07648058d
--- /dev/null
+++ b/examples/instance-servers/README.md
@@ -0,0 +1,3 @@
+# Example: Instance Servers
+
+This example provisions a customizable number of servers in a private network.
diff --git a/examples/instance-servers/main.tf b/examples/instance-servers/main.tf
new file mode 100644
index 000000000..90b41d6af
--- /dev/null
+++ b/examples/instance-servers/main.tf
@@ -0,0 +1,18 @@
+provider "scaleway" {}
+
+resource "scaleway_vpc" "vpc" {}
+
+resource "scaleway_vpc_private_network" "pn" {
+  vpc_id = scaleway_vpc.vpc.id
+}
+
+resource "scaleway_instance_ip" "ip" {
+  count = var.server_count
+}
+
+resource "scaleway_instance_server" "server" {
+  count = var.server_count
+  type = "PLAY2-MICRO"
+  image = "ubuntu_jammy"
+  ip_ids = [scaleway_instance_ip.ip[count.index].id]
+}
diff --git a/examples/instance-servers/outputs.tf b/examples/instance-servers/outputs.tf
new file mode 100644
index 000000000..a15e12fe4
--- /dev/null
+++ b/examples/instance-servers/outputs.tf
@@ -0,0 +1,3 @@
+output "ips_v4" {
+  value = scaleway_instance_server.server[*].public_ip
+}
\ No newline at end of file
diff --git a/examples/instance-servers/variables.tf b/examples/instance-servers/variables.tf
new file mode 100644
index 000000000..fa3958fbe
--- /dev/null
+++ b/examples/instance-servers/variables.tf
@@ -0,0 +1,4 @@
+variable "server_count" {
+  description = "The number of servers and IPs to provision"
+  default = 3
+}
\ No newline at end of file

From 91180dff3e7c7fe1c571a2bbeed6b89a16d327ce Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Jules=20Cast=C3=A9ran?= <jules.casteran@gmail.com>
Date: Wed, 22 May 2024 11:32:24 +0200
Subject: [PATCH 2/2] Apply suggestions from code review

Co-authored-by: Yacine Fodil <105779815+yfodil@users.noreply.github.com>
---
 examples/instance-servers/outputs.tf   | 5 +++--
 examples/instance-servers/variables.tf | 5 +++--
 2 files changed, 6 insertions(+), 4 deletions(-)

diff --git a/examples/instance-servers/outputs.tf b/examples/instance-servers/outputs.tf
index a15e12fe4..6f4a32ab8 100644
--- a/examples/instance-servers/outputs.tf
+++ b/examples/instance-servers/outputs.tf
@@ -1,3 +1,4 @@
 output "ips_v4" {
-  value = scaleway_instance_server.server[*].public_ip
-}
\ No newline at end of file
+  description = "The public IPv4 addresses of the created instance servers"
+  value       = scaleway_instance_server.server[*].public_ip
+}
diff --git a/examples/instance-servers/variables.tf b/examples/instance-servers/variables.tf
index fa3958fbe..9e1effa9f 100644
--- a/examples/instance-servers/variables.tf
+++ b/examples/instance-servers/variables.tf
@@ -1,4 +1,5 @@
 variable "server_count" {
   description = "The number of servers and IPs to provision"
-  default = 3
-}
\ No newline at end of file
+  type        = number
+  default     = 3
+}