Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play 2.4 support #25

Closed
wants to merge 2 commits into from
Closed

Play 2.4 support #25

wants to merge 2 commits into from

Conversation

0x1997
Copy link

@0x1997 0x1997 commented Feb 11, 2015

I haven't updated the play-sample project because I'm not sure about the relative loading order of injected modules and old-style plugins. Anyway, It can be updated to use https://github.com/flyway/flyway-play when that is published.

@xuwei-k
Copy link
Member

xuwei-k commented Feb 11, 2015

https://travis-ci.org/scalikejdbc/scalikejdbc-async/jobs/50314414#L1742

sbt.ResolveException: unresolved dependency: org.scalaz.stream#scalaz-stream_2.11;0.5a: not found
    at sbt.IvyActions$.sbt$IvyActions$$resolve(IvyActions.scala:278)
    at sbt.IvyActions$$anonfun$updateEither$1.apply(IvyActions.scala:175)
    at sbt.IvyActions$$anonfun$updateEither$1.apply(IvyActions.scala:157)
    at sbt.IvySbt$Module$$anonfun$withModule$1.apply(Ivy.scala:151)

@coveralls
Copy link

Coverage Status

Coverage increased (+13.91%) to 92.86% when pulling 7b2789f on 0x1997:play-2.4 into 0760d1b on scalikejdbc:develop.

@seratch
Copy link
Member

seratch commented Feb 14, 2015

Thanks. I'd like to merge this PR after play-sample updates. If flyway-play will be a blocker for long time, I'll rethink.

@tototoshi
Copy link
Member

Sorry to have kept you waiting. A snapshot version of flyway-play is now available.

resolvers +=
  "Sonatype OSS Snapshots" at "https://oss.sonatype.org/content/repositories/snapshots"

libraryDependencies ++= Seq(
  "org.flywaydb" %% "flyway-play" % "2.0.0-SNAPSHOT"
)

@seratch
Copy link
Member

seratch commented May 16, 2015

play 2.4 will be out soon. https://groups.google.com/forum/#!topic/play-framework-dev/HJncEA0svak
@0x1997 Are you still interested in working on this pull request?

@0x1997
Copy link
Author

0x1997 commented May 16, 2015

@seratch Sorry for the hiatus. Play didn't work out in that project of mine and I don't have time to finished this at the moment. Please feel free to take my code if it still works.

@xuwei-k xuwei-k mentioned this pull request Oct 8, 2015
@Tolsi
Copy link

Tolsi commented Mar 12, 2016

It is unclear whether the module is supported Play 2.4+ and that prevents this? If supported, I'd like an example.

@seratch
Copy link
Member

seratch commented Mar 12, 2016

@Tolsi No, still unsupported. Since scalikejdbc-async's connection pool is simple, it should be easy to write your own Play integration.

@xuwei-k
Copy link
Member

xuwei-k commented Dec 17, 2017

Sorry, We have deleted playframework support. #56

@xuwei-k xuwei-k closed this Dec 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants