Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WrappedResultSet#dateTime renaming plan #222

Closed
seratch opened this issue Apr 22, 2014 · 1 comment
Closed

WrappedResultSet#dateTime renaming plan #222

seratch opened this issue Apr 22, 2014 · 1 comment
Assignees
Labels
Milestone

Comments

@seratch
Copy link
Member

@seratch seratch commented Apr 22, 2014

WrappedResultSet#dateTime and so on should be used for JSR 310 classes.

Here is a migration plan (this is just my idea):

ScalikeJDBC 2.0.x
  • Mark #dateTime, #localDate, #localTime and #localDateTime as deprecated
  • Add #jodaDateTime, #jodaLocalDate, #jodaLocalTime and #jodaLocalDateTime.
ScalikeJDBC 2.1.x
  • #dateTime, #localDate, #localTime, #localDateTime returns JSR 310 values

If anyone have another plan, please share us.

@seratch seratch added this to the version 2.0.0 milestone Apr 22, 2014
@seratch seratch self-assigned this Apr 22, 2014
@seratch seratch added the library label Apr 22, 2014
seratch added a commit that referenced this issue Apr 22, 2014
…Time renaming plan
seratch added a commit that referenced this issue Apr 22, 2014
@seratch seratch modified the milestones: version 2.1.0, version 2.0.0 Apr 29, 2014
seratch added a commit that referenced this issue Aug 10, 2014
 - Add scalikejdbc-jsr310 for Java 8 users
 - Remove depreacated methods from scalikejdbc.WrappedResultSet
 - This change should be released as 2.1.0 due to API incompatibility
seratch added a commit that referenced this issue Aug 19, 2014
Add optional JSR-310 support library (refs #222)
@seratch
Copy link
Member Author

@seratch seratch commented Aug 28, 2014

Done.

@seratch seratch closed this Aug 28, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.