Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

requirements: Run pip-compile #469

Closed
wants to merge 1 commit into from
Closed

requirements: Run pip-compile #469

wants to merge 1 commit into from

Conversation

NicolasT
Copy link
Contributor

@NicolasT NicolasT commented Nov 6, 2018

Version 2.19.1 and below of the requests library contain a security
issue, fixed in 2.20.0 (cfr. CVE-2018-18074).

See: https://nvd.nist.gov/vuln/detail/CVE-2018-18074

@NicolasT NicolasT added the kind:enhancement New feature or request label Nov 6, 2018
@NicolasT NicolasT added this to the MetalK8s 1.1.0 milestone Nov 6, 2018
@NicolasT NicolasT requested a review from a team November 6, 2018 18:02
@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2018

Hello NicolasT,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get
information on this process.

Status report is not available.

@bert-e bert-e mentioned this pull request Nov 6, 2018
Closed
@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2018

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0

Follow integration pull requests if you would like to be notified of
build statuses by email.

@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2018

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • one peer

Peer approvals must include at least 1 approval from the following list:

@NicolasT
requirements: Run pip-compile
376cde7 
Version 2.19.1 and below of the `requests` library contain a security
issue, fixed in 2.20.0 (cfr. CVE-2018-18074).

See: https://nvd.nist.gov/vuln/detail/CVE-2018-18074
@NicolasT NicolasT force-pushed the improvement/update-requirements branch from f55ef18 to 376cde7 Compare November 6, 2018 18:02
@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2018

History mismatch

Merge commit #f55ef18513df34541b3aa03e133a67d773b0de4d on the integration branch
w/1.2/improvement/update-requirements is merging a branch which is neither the current
branch improvement/update-requirements nor the development branch
development/1.2.

It is likely due to a rebase of the branch improvement/update-requirements and the
merge is not possible until all related w/* branches are deleted or updated.

Please use the reset command to have me reinitialize these branches.

@NicolasT
Copy link
Contributor Author

NicolasT commented Nov 6, 2018

@bert-e reset

@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2018

Reset complete

I have successfully deleted this pull request's integration branches.

@bert-e bert-e mentioned this pull request Nov 6, 2018
Closed
@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2018

Integration data created

I have created the integration data for the additional destination branches.

The following branches will NOT be impacted:

  • development/1.0

Follow integration pull requests if you would like to be notified of
build statuses by email.

@bert-e
Copy link
Contributor

bert-e commented Nov 6, 2018

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • one peer

Peer approvals must include at least 1 approval from the following list:

@NicolasT
Copy link
Contributor Author

NicolasT commented Nov 6, 2018

Abandoning for a 1.0 approach.

@NicolasT NicolasT closed this Nov 6, 2018
@NicolasT NicolasT deleted the improvement/update-requirements branch November 6, 2018 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
kind:enhancement New feature or request
Projects
None yet
Milestone
MetalK8s 1.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@NicolasT @bert-e