Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add `returnValues` support for put/update/delete operations #149

Closed

Conversation

Projects
None yet
2 participants
@amirkarimi
Copy link
Contributor

commented Oct 4, 2017

By setting ReturnValues for put, update and delete requests we will be able to get the item attributes as they appeared before they were updated.

@philwills

This comment has been minimized.

Copy link
Contributor

commented Oct 5, 2017

Thanks for this @amirkarimi, a few thoughts:

@amirkarimi

This comment has been minimized.

Copy link
Contributor Author

commented Oct 9, 2017

@philwills My problem with update is that I can't just pass an object to it to be upserted (though it's possible to create an UpdateExpression using DynamoFormat?). Anyway, do you suggest making put like update to return the fully hydrated object?

@philwills

This comment has been minimized.

Copy link
Contributor

commented Oct 11, 2017

Yes, I was suggesting that returning the fully hydrated object from put would be an alternative approach that I believe would fitter with the wider design.

I wasn't suggesting that update was a suitable alternative for this use case.

@amirkarimi

This comment has been minimized.

Copy link
Contributor Author

commented Oct 11, 2017

@philwills Thanks for the explanation. I'll resolve the conflicts and follow this approach.

@amirkarimi amirkarimi closed this Oct 15, 2017

@amirkarimi amirkarimi deleted the amirkarimi:feature/support-return-value branch Oct 15, 2017

@amirkarimi amirkarimi referenced this pull request Oct 15, 2017

Merged

Return overwriting item as put operation result #153

4 of 4 tasks complete
@amirkarimi

This comment has been minimized.

Copy link
Contributor Author

commented Oct 15, 2017

As we decided to implement this feature in another way I just deleted the previous branch and created a new one from master. Deletion caused this PR to be closed. Anyway, this PR is continued at #153

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.