Seph Soliman
scarlac

  • Joined on Jul 5, 2011
Jul 16, 2016
@scarlac
angular support
Jul 16, 2016
scarlac commented on issue scarlac/drag-check-js#3
@scarlac

Great! I'll keep native Angular support in mind for the next versions :)

Jul 16, 2016
scarlac commented on issue scarlac/drag-check-js#3
@scarlac

Angular needs to know about changes, and apparently it doesn't listen to change events, only click events (it assumes it's the only one controlling…

Jul 16, 2016
scarlac commented on issue scarlac/drag-check-js#3
@scarlac

Hey @twilly86, have you tried making sure it waits until Angular has rendered the checkboxes? Example: $timeout(function() { /* setup code for drag…

Jul 11, 2016
scarlac commented on issue webpack/webpack.io#21
@scarlac

Assumption: We'll want to keep "Getting started" simple and targeted (mostly) for newbies. If that assumption is wrong, these suggestions will not …

Jul 10, 2016
Jul 3, 2016
Jun 10, 2016
Jun 5, 2016
@scarlac
Playground stays disabled
Jun 3, 2016
@scarlac
  • @scarlac d857bc2
    resetting these vars are no longer necessary
Jun 3, 2016
scarlac commented on pull request github/fetch#335
@scarlac

I believe you are correct. Since we're now reusing old references, it would always be the same type and thus a delete is unnecessary. I'm removing …

Jun 3, 2016
scarlac commented on issue github/fetch#308
@scarlac

@mislav, Let me know if you need more changes to the PR for it to be acceptable. I'll be happy to refine it further.

May 29, 2016
@scarlac
May 29, 2016
May 29, 2016
May 27, 2016
scarlac commented on pull request github/fetch#335
@scarlac

I've added a test in the latest commit. It may be that this test would never actually since blobs can be re-read without problems normally but it d…

May 27, 2016
@scarlac
  • @scarlac 81bd819
    Added test for reading Request clone blob
May 27, 2016
scarlac commented on pull request github/fetch#335
@scarlac

Ah I see what you mean. That makes sense to do. I'm writing a test now although it seems to 'just work' so I just need to make sure it's testing pr…

May 27, 2016
@scarlac
May 27, 2016
scarlac commented on pull request github/fetch#335
@scarlac

You're right again :)

May 27, 2016
scarlac commented on pull request github/fetch#335
@scarlac

I'm unsure since I haven't touched on that part of the code but if we're not polyfilling Blob I'd say it seems a bit unnecessary to test the browse…

May 27, 2016
scarlac commented on pull request github/fetch#335
@scarlac

You're right, they're not. I'll remove.

May 27, 2016
scarlac commented on pull request github/fetch#335
@scarlac

You're right. That would be much simpler. I'll fix that!

May 27, 2016
scarlac commented on pull request github/fetch#335
@scarlac

That's where I had them initially. I moved them to initBody since it's responsible for setting them. For future maintenance it seemed easier if the…

May 27, 2016
scarlac commented on issue github/fetch#308
@scarlac

I had a look. The spec wants a copy of the Request for clone() but without the body which will be copied separately by re-reading the original stre…

May 27, 2016
@scarlac
  • @scarlac 35ed4c3
    Fixes #308. Avoid consuming same body when cloning
May 27, 2016
scarlac opened pull request github/fetch#335
@scarlac
Fixes #308. Avoid consuming same body when cloning
1 commit with 21 additions and 1 deletion
May 27, 2016
May 16, 2016
@scarlac
Reloading causes "Warning: You cannot PUSH the same path using hash history" with react-router-redux
May 16, 2016
@scarlac

I think it's realistic to assume that cherry-picking from react-router(-redux) state can cause some pretty exotic bugs that you can't issue reports…