New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISSUE-145: Akka configuration fix #147

Merged
merged 1 commit into from Apr 8, 2016

Conversation

Projects
None yet
2 participants
@pzapletal
Contributor

pzapletal commented Apr 7, 2016

Fixes problem described here - #145
Users of stubbed cassandra are not restricted to defined akka.version anymore.

  • Ready for review
@chbatey

This comment has been minimized.

Show comment
Hide comment
@chbatey

chbatey Apr 7, 2016

Member

The failed tests look to be because the cassandra driver's error messages have changed. I'll fix that in master and you can rebase and make sure that is the case.

Member

chbatey commented Apr 7, 2016

The failed tests look to be because the cassandra driver's error messages have changed. I'll fix that in master and you can rebase and make sure that is the case.

@pzapletal

This comment has been minimized.

Show comment
Hide comment
@pzapletal

pzapletal Apr 7, 2016

Contributor

okay, would be really surprised if I broke it

Contributor

pzapletal commented Apr 7, 2016

okay, would be really surprised if I broke it

@chbatey

This comment has been minimized.

Show comment
Hide comment
@chbatey

chbatey Apr 7, 2016

Member

Yep, the only thing I could imagine this breaking is the far jar build which the build didn't get to

Member

chbatey commented Apr 7, 2016

Yep, the only thing I could imagine this breaking is the far jar build which the build didn't get to

@pzapletal

This comment has been minimized.

Show comment
Hide comment
@pzapletal

pzapletal Apr 7, 2016

Contributor

yeah, let me know when done and I'll rebase & push

Contributor

pzapletal commented Apr 7, 2016

yeah, let me know when done and I'll rebase & push

@chbatey

This comment has been minimized.

Show comment
Hide comment
@chbatey

chbatey Apr 7, 2016

Member

Should be good to go now

On 7 Apr 2016, at 19:34, Petr Zapletal notifications@github.com wrote:

yeah, let me know when done and I'll rebase & push


You are receiving this because you commented.
Reply to this email directly or view it on GitHub

Member

chbatey commented Apr 7, 2016

Should be good to go now

On 7 Apr 2016, at 19:34, Petr Zapletal notifications@github.com wrote:

yeah, let me know when done and I'll rebase & push


You are receiving this because you commented.
Reply to this email directly or view it on GitHub

@chbatey chbatey merged commit b6499c4 into scassandra:master Apr 8, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment