New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle invalid types with an informative error message, update docs. #150

Merged
merged 1 commit into from Apr 15, 2016

Conversation

Projects
None yet
2 participants
@tolbertam
Contributor

tolbertam commented Apr 14, 2016

Noticed that some of the docs inappropriately reference a 'set' column_type without providing a parameterized value. This used to work but no longer does, when it does the error returned is not very useful:

The request content was malformed:

Updated ColumnType.fromString to handle any parsing errors emitted by CqlTypeFactory.buildType and returning Try instead of Option and then handling the Failure case in PrimingJsonImplicits.ColumnTypeJsonFormat.

The error now includes the relevant info:

The request content was malformed:
Not a valid column type 'set'

and the full stack trace is emitted in the logs.

@tolbertam tolbertam self-assigned this Apr 14, 2016

@tolbertam tolbertam added the bug label Apr 14, 2016

@chbatey chbatey merged commit 8237118 into scassandra:master Apr 15, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment