Handle the case of a firehose.url_id column pointing to a missing row

gracefully (throwing a fatal error, it turns out, does not qualify as graceful)
scc · Dec 6, 2007 · 24ae61f · 24ae61f
1 parent b257743
commit 24ae61f
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/plugins/FireHose/FireHose.pm b/plugins/FireHose/FireHose.pm
@@ -771,8 +771,9 @@ sub allowSubmitForUrl {
 sub getURLsForItem {
 	my($self, $item) = @_;
 	my $url_id = $item->{url_id};
-	my $url =         $url_id ? $self->getUrl($url_id)->{url} : undef;
-	my $url_prepend =    $url ? qq{<a href="$url">$url</a>}   : '';
+	my $url = $url_id ? $self->getUrl($url_id) : undef;
+	$url = $url->{url} if $url;
+	my $url_prepend = $url ? qq{<a href="$url">$url</a>}   : '';
 	my $text = qq{$url_prepend $item->introtext $item->{bodytext}};
 
 	my %urls = ( );