From e302a74d975507b977b1e3ff39dae8ee5a8d7deb Mon Sep 17 00:00:00 2001 From: Brian Aker Date: Fri, 5 Apr 2002 20:18:24 +0000 Subject: [PATCH] Calling getUser() without params means six way join. This is stupid --- themes/slashcode/htdocs/comments.pl | 14 ++++++++++---- 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/themes/slashcode/htdocs/comments.pl b/themes/slashcode/htdocs/comments.pl index 6f5bd1b87..9e202bd32 100755 --- a/themes/slashcode/htdocs/comments.pl +++ b/themes/slashcode/htdocs/comments.pl @@ -1224,13 +1224,19 @@ sub moderateCid { # Adjust comment posters karma and moderation stats. if ($comment->{uid} != $constants->{anonymous_coward_uid}) { - my $cuser = $slashdb->getUser($comment->{uid}); + my $cuser = $slashdb->getUser($comment->{uid}, [ qw| downmods upmods karma | ]); my $newkarma = $cuser->{karma} + $val; $cuser->{downmods}++ if $val < 0; $cuser->{upmods}++ if $val > 0; - $cuser->{karma} = $newkarma - if $newkarma <= $constants->{maxkarma} && - $newkarma >= $constants->{minkarma}; + if ($val < 0) { + $cuser->{karma} = $newkarma; + } else { + $cuser->{karma} = $newkarma + if $newkarma <= $constants->{maxkarma}; + } + $cuser->{karma} = $constants->{minkarma} + if $newkarma < $constants->{minkarma}; + $slashdb->setUser($comment->{uid}, { karma => $cuser->{karma}, upmods => $cuser->{upmods},