Skip to content
This repository

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Browse code

Don't show inline firehose ad on external links

  • Loading branch information...
commit f5092bed88a635807e6033c312bcf0e5c563196c 1 parent 097bba8
Chris Nandor authored December 15, 2008

Showing 1 changed file with 6 additions and 3 deletions. Show diff stats Hide diff stats

  1. 9  plugins/Ajax/htdocs/images/common.js
9  plugins/Ajax/htdocs/images/common.js
@@ -594,10 +594,13 @@ function firehose_toggle_tag_ui( toggle ) {
594 594
 }
595 595
 
596 596
 function firehose_click_tag( event ) {
597  
-	// _any_ click can trigger, but click-specific ad will win
598  
-	setTimeout(function(){ inlineAdFirehose(); }, 0);
  597
+	var $target = $(event.target), command = '', $menu;
599 598
 
600  
-	var $target = $(event.target), command='', $menu;
  599
+	// skip for non-JS hrefs
  600
+	if (! $(target).find_nearest('a[href]:not([href=#])', 'self', 'up').length) {
  601
+		// _any_ click can trigger, but click-specific ad will win
  602
+		setTimeout(function(){ inlineAdFirehose(); }, 0);
  603
+	}
601 604
 
602 605
 	$related_trigger = $target;
603 606
 

0 notes on commit f5092be

Please sign in to comment.
Something went wrong with that request. Please try again.