Permalink
Commits on Aug 21, 2008
  1. For admins only, add a 'note' signal in hose entry titles

    scc committed Aug 21, 2008
    It's not a button, just a flag.
  2. update

    pudge committed Aug 21, 2008
  3. Add error handling for xsite auth

    pudge committed Aug 21, 2008
  4. Make IE 7 work for D2, change errorLog()

    pudge committed Aug 19, 2008
    Make errorLog() put all errors on one line for easier grepping
    Make D2 work for IE7 (still not for IE <= 6)
  5. firehose rss links

    tvroom committed Aug 21, 2008
Commits on Aug 20, 2008
  1. Implement a tiny plugin for jQuery: $.TextSelection

    scc committed Aug 20, 2008
    ...necessary for upcoming fix to prevent the tagui autocomplete field/menu from
    dropping selection/focus/visibility on hose refresh.
  2. fix title for idle articles

    tvroom committed Aug 20, 2008
  3. generate more firehose rss feeds

    tvroom committed Aug 20, 2008
  4. Change how firehose is titled

    tvroom committed Aug 20, 2008
  5. Add idle slashboxes to rotation

    tvroom committed Aug 20, 2008
  6. TagUI: bring back the disclosure triangle for anonymous == login

    scc committed Aug 20, 2008
    ...and simplify the template logic now that we have a tags_canwrite_stories and
    else fork.
  7. Restore the original layout of the firehose tag-widget

    scc committed Aug 20, 2008
    That is ---
    admin
    	collapsed:	triangle,             top, system, signoff
    	expanded:	triangle, edit,	user, top, system, signoff, busy
    signed-in
    	collapsed:	triangle,             top, system
    	expanded:	triangle, edit,	user, top, system,          busy
    anonymous
    	only mode:	                      top, system
    
    Within the 'system' bar, the elements are: datatype, section, topic.
    
    I think this order is much more natural, and it's what we originally envisioned.
Commits on Aug 19, 2008
  1. Teach ajaxSetGetCombinedTags to limit its search; get tags right at t…

    scc committed Aug 19, 2008
    …emplate time
    
    ajaxSetGetCombinedTags will now fetch only system and top tags when you don't
    supply a user.  This makes it perfect for filling in the templates which don't
    initially show user tags.
    
    Added a non-ajax interface, setGetCombinedTags, parallel to the Tags.pm's
    ajaxSetGetCombinedTags functionality; which we now call from the appropriate
    places in FireHose.pm.  We still call the old $fh->getFirehHoseTagsTop,
    though---I've given the template parameters different names---so anything still
    using tags_top will continue to function.  We don't need to worry about caching,
    because dispFireHose does it for us!
    
    In the near future, I may further split <system> tags into datatype, section,
    main topic, topics, so that I can implement the drag-and-drop facility.
  2. When meta-moderating: nod/nix immediately rolls up the comment, no su…

    scc committed Aug 19, 2008
    …ggestions
    
    firehose_handle_comment_nodnix previously relied on the more general
    firehose_handle_nodnix to: (a) set the context; and (b) fix the +/- capsule.
    
    At Jamie's suggestion, we now _don't_ want to set the context (i.e., offer no
    suggestions), just immediately "roll-up" the comment.  So we no longer call
    firehose_handle_nodnix, and instead (a) clear the context ourselves; (b) fix the
    vote state (+/- capsule) ourselves; and finally (c) roll up the comment with
    collapse_firehose_entry.
    
    Now that the special comment version doesn't call the general case, we can strip
    out the special handling that firehose_handle_nodnix supplied for us, allowing
    us to pass in the desired context name.
  3. Enable the new tagui for Idle

    scc committed Aug 19, 2008
  4. updates to m2text

    Timothy Vroom committed Aug 19, 2008
  5. In the tagui: differentiate admin-only contexts; move history button …

    scc committed Aug 19, 2008
    …to suggestions
    
    Now, if applications add a 'modify_context' function to a widget, then I will
    call it immediately after setting the context tags, but only in the case of
    adding new suggestions... not when clearing the existing context.
    
    	- added firehose_admin_context(), which is just such a function, to add
    		'history' as a command in the suggestions bar for admins
    	- taught firehose_handle_admin_commands to notice 'history'
    	- moved the tagsHistory function to be defined before used
    	- taught tagsHistory to hang the history panel from the first available
    		of: { the history button, the thing the user clicked, the dis-
    		closure triangle, or if all else fails, the nod/nix capsule }
    	- upgraded getXYForId to getXYForSelector, now presumes we are using jQuery
    	- fixed all callers of getXYForId
    	- taught set_context to call the new context tags 'suggestions'
    	- moved the declaration of 'widget' "up" in set_context to accomodate the
    		new callback
    	- refined the CSS selector to apply to 'suggestions' instead of everything
    		in the context display
    	- only add the data-type contexts for admins (template init_tagui)
    	- deleted the history button from the tag-widget template
Commits on Aug 18, 2008
  1. Fixes to satisfy JSLint

    scc committed Aug 18, 2008
    Using JSLint <http://jslint.com/> to flight-check our JavaScript.  Did some
    fixing and some hand-waving in the three big JS files: common.js, admin.js and
    tagui.js.
    
    Fixes:
    	- insert semicolons where needed
    	- all ifs, elses, whiles, and fors require blocks
    	- use foo.bar when possible over foo['bar']
    	- when comparing with 0, null, undefined, and '', use === and !==
    	- use new when constructing from a prototype
    	- use [] instead of new Array(); {} instead of new Object()
    	- supply radix in calls to parseInt
    	- to avoid JS auto-inserted ';', only break lines after punctuation (except in hashes)
    	- where reasonable, define variables and functions before use
    	- when looping with 'for (m in obj)', always filter with hasOwnProperty
    	- do some escaping in regular expressions where parsers may disagree
    	- be more careful about how 'var' and 'function' are used within functions
    	- note that the 'catch' expression is also a declaration
    
    	- in common.js:function json_update, cleanup involved renaming some
    		variables to make the code read a little plainer
    
    Hand-Waving:
    	- added a /*global ... */ comment in common.js to squelch JSLint's
    		complaints about use before definition
    	- wrapped the three valid uses of 'eval' in /*jslint evil: true */, and
    		then false to squelch JSLint's complaints that eval is evil
    
    Ignoring:
    	- warnings that the initial ';' is not needed
    	- that we should be careful when making functions within a loop (we know
    		what we're doing)
    	- spurious complaints about '<' in regular expressions (it's a JSLint bug)
Commits on Aug 15, 2008
  1. update

    pudge committed Aug 15, 2008
Commits on Aug 14, 2008
  1. update

    pudge committed Aug 14, 2008
  2. Make the pop-up hover menu for tags horizontal and green, as per Rob'…

    Wes Moran committed with scc Aug 14, 2008
    …s request
  3. Fix "read" bug

    pudge committed Aug 14, 2008
    We have two ways of tracking read comments, one for what has been read and
    recorded in the DB, and one for what has yet to be sent to the DB for recording.
    Check both for isUnread().
  4. fixing tagui menus

    Wes Moran committed Aug 14, 2008
Commits on Aug 13, 2008
  1. update

    pudge committed Aug 13, 2008