Commits on Sep 5, 2008
  1. @pudge


    pudge committed Sep 5, 2008
  2. @jamiemccarthy

    Multiple small bugfixes: tags, email/subs, crashes

    email_to_domain works now, with the bonus that does not
    crash and eat submissions.  Fixed multiple Tags and Tagbox
    incorrect references (also crashes) for e.g. [History] view.
    Got forceFeederRecalc working correctly from createItemFromComment
    and Despam.  Fixed tagboxLog as called (indirectly) from web via
    firehose API.  Grouped tag filtering through _do_default_filter()
    and added a publiconly option, which Top now uses to keep "nod" and
    "nix" from showing up.  Passed options through run() to run_process()
    and fixed FireHoseScores to correctly use it.  Added metanod and
    metanix as private tags.
    jamiemccarthy committed Sep 5, 2008
  3. Bugfix: when closed, tagui menus _seemed_ broken; but really they jus…

    …t lacked feedback
    committed Sep 5, 2008
  4. @jamiemccarthy

    More bugfixes

    jamiemccarthy committed Sep 4, 2008
  5. @jamiemccarthy
  6. @jamiemccarthy


    Minor missing lines of code after Slash::Plugin and Slash::Utility
    jamiemccarthy committed Sep 4, 2008
  7. @pudge

    add module

    pudge committed Sep 4, 2008
  8. @pudge

    fix typos

    pudge committed Sep 4, 2008
Commits on Sep 4, 2008
  1. @jamiemccarthy

    SearchToo bugfix

    The bug had prevented Slash::SearchToo::Foo from being seen
    as installed, which rendered the plugin essentially worthless.
    jamiemccarthy committed Sep 4, 2008
  2. @pudge


    pudge committed Sep 4, 2008
  3. @pudge
  4. @jamiemccarthy

    Misc. bugfixes

    Mostly fixing up things I missed when removing some 'use's I had thought
    were unnecessary, and some plugin class inheritance oversights.
    jamiemccarthy committed Sep 4, 2008
  5. firehose_click_tag should show_login_box for anon users; use $.trim i…

    …nstead of my own regexp
    committed Sep 4, 2008
  6. @tvroom

    Fix anon link for days

    tvroom committed Sep 4, 2008
  7. @tvroom

    allow get more for anon user

    tvroom committed Sep 4, 2008
  8. @tvroom
  9. @tvroom
  10. @tvroom
  11. @tvroom

    Updates for get more for anon

    tvroom committed Sep 4, 2008
  12. @tvroom

    Updates to add more for anon

    tvroom committed Sep 4, 2008
  13. @jamiemccarthy


    Allow editors to not see some of the comments in the hose
    jamiemccarthy committed Sep 4, 2008
  14. @jamiemccarthy

    Tagbox bugfixes

    info_log/debug_log log accurately now.  getTagboxTags includes tagname
    for each tag.  forceFeederRecalc uses valid SQL.  constrain_score call
    doesn't crash.  FireHoseScores doesn't crash.  Clouts added.
    jamiemccarthy committed Sep 3, 2008
  15. @jamiemccarthy

    Correct doc error

    jamiemccarthy committed Sep 3, 2008
  16. @jamiemccarthy

    Slash::Tagbox refactoring nearing completion

    Removed the tagbox_userkeyregexes table, and 3 columns from tagboxes
    table, replaced with class methods which S::T subclasses may override.
    {nodid},{nixid} in all S::T objects. now runs more quickly and efficiently.  A code comment
    in and slashd has thoughts on future multiprocessing
    changes.  Modernized logging.
    Removed some unnecessary 'use's.  getTagboxTags() now filters tags
    at each step, for a (possibly dramatic in some cases) speed
    improvement.  Tagbox filtering in _do_filter_foo submethods.  API
    changes to be OOP-appropriate for addFeederInfo(), forceFeederRecalc()
    and other (now-) methods.
    The API and subclasses' calls of it is still a little rough.
    jamiemccarthy committed Sep 3, 2008
  17. @jamiemccarthy

    Bugfix: get nosy tagboxes working

    I'm not sure why it didn't enter a loop of infinite crashing with the
    first globj that a nosy tagbox wanted, but that aside, this fixes
    that bug and allows nosy tagboxes to get notification of new globjs.
    jamiemccarthy committed Aug 23, 2008
  18. @jamiemccarthy
  19. @jamiemccarthy

    Promote common global functions from Slash/ to

    Some of the global functions that 'use Slash::Utility' EXPORTs are
    common enough that they should be available everywhere.  So I'm
    promoting getObject, getCurrentStatic, and 12 others to's
    EXPORT list.
    This doesn't change anything about what code is require'd, it only
    saves some sections of our code from needing a 'use Slash::Utility'
    or maybe 'use Slash::Utility::Environment'.
    jamiemccarthy committed Aug 22, 2008
  20. @jamiemccarthy

    Get database class inheritance working properly, esp. for plugins/tag…

    new(), isInstalled() and init() have never worked properly due mostly
    to mishandled multiple inheritance.  This sets classes up correctly,
    notably adding Slash::Plugin as a viable base class for most plugin
    database classes (rewriting many common ones to do that), also adding
    Slash::Tagbox as the base class for all tagboxes (and adding some
    convenience methods to simplify tag processing).
    It is believed that old code not changed to use the new base classes
    will work the same as before.
    As of this commit, this code should be considered beta -- it's not
    ready for production, in particular I'm pretty sure tagboxes don't
    run due to a getTagboxes() bug.
    jamiemccarthy committed Aug 15, 2008
Commits on Sep 2, 2008
  1. @pudge


    pudge committed Sep 2, 2008
Commits on Aug 30, 2008
  1. @jamiemccarthy

    Fix minor futurestorybox issues

    display;article;* does not use the 'authortext' field to display to
    admins information about past and future stories, so don't bother
    populating that field.  Correct misnamed variable holding
    futurestorybox;*;* output (actually, "futurestorybox" is a rather
    dumb name but might as well leave it).  Add needed_signoffs field
    when displays futurestorybox.  Remove unnecessarily
    customized slashdot theme futurestorybox;misc;default and copy its
    (minor) improvements back into main plugin.
    It's believed that these changes will eliminate the plethora of
    "Argument "" isn't numeric in numeric lt (<) at 233 line 2" in
    Slashdot's admin webhead error log.  Woo.
    jamiemccarthy committed Aug 30, 2008