Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with HTTPS or Subversion.

Download ZIP
Commits on Oct 9, 2008
  1. @pudge

    No need for introtext there

    pudge authored
  2. @pudge

    update

    pudge authored
  3. @pudge

    Fix broken introtext stuff

    pudge authored
  4. Safari tag img underline fix

    Vlad Kulchytskyy authored
  5. @pudge

    Fix linkComment stuff srsly

    pudge authored
  6. @pudge

    Fix linkComment for realsies

    pudge authored
  7. @pudge

    Fix URLs

    pudge authored
  8. Need $().tag_ui__tags() function but it is not yet integrated; until …

    authored
    …then we will hand-code it
  9. @tvroom
  10. @pudge
  11. @pudge

    Journal introtext fixes

    pudge authored
  12. @pudge

    Fix API call

    pudge authored
    Is key() not get_key()
  13. @pudge

    Journal things

    pudge authored
    Add "introtext" column
    
    Properly populate tags for all Journal Firehose entries
    
    Update journal/firehose import script
  14. @pudge

    Dynamic ad updates

    pudge authored
  15. @pudge

    Misc. thingys

    pudge authored
  16. @pudge

    Drop timer

    pudge authored
  17. @pudge

    No closures in .pl's

    pudge authored
  18. @pudge

    Add email for cross-site users

    pudge authored
  19. @tvroom

    Change slashbox widths

    tvroom authored
  20. prefs_messages;ajax;default: Added admin options for Console display

    Christopher Brown authored
    display;remarks;default: Made story titles links, removed the '[Edit]' link, and increased
    the number of characters in the title's display.
  21. Fixing positioning of tag collased for unregisted users

    Vlad Kulchytskyy authored
  22. Fixing tag widget running into "READ MORE"

    Vlad Kulchytskyy authored
  23. Making tags colour on .head #fff

    Vlad Kulchytskyy authored
  24. Floating slashbox ad: deal with updates, no screen pinning, speed up …

    authored
    …articles_on_screen()
    
    After a demo, Rob asked me to remove pinning to the screen; logic simplified accordingly.
    Added 'articlesMoved' event to #firehoselist; trigger it in almost all the places needed.
    Bind fix_ad_position() to this event.  Ads cannot be detached from their articles, so
    removed detach from the interface.  Similarly, only 300x300 will be supported, so no more
    set_size().
    
    Patrick McGarry notes that we may want to remove an ad if its article gets collapsed high
    enough in the firehose that the ad (pinned to the bottom of your slashboxes) no longer
    has any overlap with it.  To allow for this case and others, added events on the ad
    container itself; clients use Slash.Firehose.floating_slashbox_ad.bind/unbind as they
    would for any event.
    
    Under the assumption that firehose articles are displayed in order from top to bottom, we
    can improve the logic for finding the on-screen subset.  Previous code looked at every
    element, and calculated every value from scratch at each step.  With this commit, I
    search testing the minimal values until I find the first on-screen article in the list;
    then continue calculating _only_ the article tops until I find the first article below
    the screen.  I then break out of the list.  So I may examine very few elements.  The code
    could be faster for large lists where you are looking near the end of the list on screen
    by doing a binary search instead of linear.  For lists of smaller than a few hundred
    articles, binary search would probably be overkill.
Commits on Oct 8, 2008
  1. Floating Slashbox Ad for the firehose

    authored
    This commit adds the package Slash.Firehose.floating_slashbox_ad, and two extra methods
    to Slash.Firehose itself: choose_article_for_next_ad(), and articles_on_screen().
    
    Use it like this:
    
    	// Let's make a short-cut.
    	var floating_ad = Slash.Firehose.floating_slashbox_ad;
    
    	...
    
    	if ( ! floating_ad.is_visible() ) {
    		var $article = Slash.Firehose.choose_article_for_next_ad();
    
    		... get an iframe (or other ad content) from the ad server ...
    
    		floating_ad(ad_content, $article);
    	}
    
    The ad will be top-aligned with the article, but pinned to the bounds of the window
    and the empty space in the slashboxes column.  When the attached article is off-screen,
    the ad will be hidden.  If the attached article is scrolled back on-screen, the ad will
    be re-shown.
    
    If no article is provided (or if you call floating_ad.detach()), then the ad is not
    constrained by an article.  Setting an ad, as above, automatically clears the
    current ad; but you can do this manually as well: floating_ad.remove().  The ad position
    is 300px x 300px, unless you call floating_ad.set_size(new_height, new_width).  The
    new height must be an integer number of pixels, but the new width can be symbolic, e.g.,
    '100%'.  You can recover the article to which the current ad is attached with
    floating_ad.current_article().
    
    Slash.Firehose.articles_on_screen() returns a jQuery selection of all the articles that
    are currently visible and intersect the window bounds (even by 1px).  choose_article_for_next_ad()
    calls articles_on_screen() and then randomly selects an element from the returned list.
    
    Probably want to add code to the slashbox machinery to ensure the sentinel introduced here
    remains last in the list.
Commits on Oct 7, 2008
Commits on Oct 6, 2008
Commits on Oct 4, 2008
  1. @jamiemccarthy

    Despam typofix

    jamiemccarthy authored
Commits on Oct 3, 2008
  1. @jamiemccarthy
  2. @jamiemccarthy
  3. @jamiemccarthy
Something went wrong with that request. Please try again.