Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swing HiDPI fixes #289

Merged
merged 5 commits into from Dec 18, 2019
Merged

Swing HiDPI fixes #289

merged 5 commits into from Dec 18, 2019

Conversation

@skalarproduktraum
Copy link
Member

skalarproduktraum commented Dec 18, 2019

This PR fixes issues with HiDPI rendering on Windows and OSX (Linux untested so far).

@codecov

This comment has been minimized.

Copy link

codecov bot commented Dec 18, 2019

Codecov Report

Merging #289 into master will increase coverage by 0.02%.
The diff coverage is 54.43%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #289      +/-   ##
============================================
+ Coverage     23.69%   23.71%   +0.02%     
============================================
  Files           121      121              
  Lines         16983    17019      +36     
  Branches       2354     2361       +7     
============================================
+ Hits           4024     4036      +12     
- Misses        12956    12980      +24     
  Partials          3        3
Flag Coverage Δ Complexity Δ
#unittests 23.71% <54.43%> (+0.02%) 0 <0> (-757) ⬇️
Impacted Files Coverage Δ Complexity Δ
...raphics/scenery/controls/MouseAndKeyHandlerBase.kt 63.36% <ø> (ø) 0 <0> (-27) ⬇️
...graphics/scenery/backends/opengl/OpenGLRenderer.kt 0% <0%> (ø) 0 <0> (ø) ⬇️
...n/kotlin/graphics/scenery/controls/InputHandler.kt 85.42% <50%> (ø) 0 <0> (-11) ⬇️
...raphics/scenery/controls/GLFWMouseAndKeyHandler.kt 57.14% <66.67%> (-0.06%) 0 <0> (-43)
...raphics/scenery/controls/JOGLMouseAndKeyHandler.kt 69.68% <90.48%> (+0.62%) 0 <0> (-42) ⬇️
...aphics/scenery/controls/SwingMouseAndKeyHandler.kt 68.72% <95.45%> (+0.99%) 0 <0> (-40) ⬇️
...n/kotlin/graphics/scenery/utils/ExtractsNatives.kt 91.18% <0%> (-1.47%) 0% <0%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 476d3ff...4e4ea7f. Read the comment docs.

@skalarproduktraum skalarproduktraum merged commit 7d3b58a into master Dec 18, 2019
7 checks passed
7 checks passed
Codacy/PR Quality Review Up to standards. A positive pull request.
Details
codecov/patch 54.43% of diff hit (target 23.69%)
Details
codecov/project 23.71% (+0.02%) compared to 476d3ff
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
@skalarproduktraum skalarproduktraum deleted the swing-hidpi-fixes branch Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant
You can’t perform that action at this time.