Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small ameliorations #4

Conversation

marene
Copy link

@marene marene commented Jan 5, 2019

Hi!

First, I wanted to thank you for this great tool, that really did help me, and made me discover the multiprocessing lib, which I didn't know of, but surely will open many possibilities for future python tools and scripts I may write :D

This pr does two things:

  • Use list comprehension instead of for loops to populate arrays
  • Add a MIN_POSITIONS_NUMBER constant, which is the minimum number of position that can be used to create an android lock pattern (which is 3 in previous android versions, and is now 4), so that only patterns of minimum length of 3 are checked to save some time

…a minimum number of positions (which is 3)
@marene marene force-pushed the use_list_comprehension_and_use_minimum_positions_number branch from 94169c7 to e35e0ca Compare January 5, 2019 11:30
@sch3m4 sch3m4 merged commit d771fec into sch3m4:master Mar 19, 2019
@sch3m4
Copy link
Owner

sch3m4 commented Mar 19, 2019

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants