Permalink
Browse files

splitting to a remote server would cause "already busy" errors.

Specifically:
	client.ClientError: already busy with command 'receive-objects'

That's because recent changes removed the call to onclose() from
PackWriter_Remote.  Now it's back, plus I added an extra unit test to reveal
the problem.
  • Loading branch information...
1 parent b21314b commit 0f296c0eb7e9130a73f4b4c8c66fe7cd86cd4c1d @apenwarr apenwarr committed Jan 6, 2010
Showing with 3 additions and 0 deletions.
  1. +2 −0 client.py
  2. +1 −0 test-sh
View
@@ -199,6 +199,8 @@ def _end(self):
id = self.file.readline().strip()
self.file.check_ok()
self.objcache = None
+ if self.onclose:
+ self.onclose()
return id
def close(self):
View
@@ -18,6 +18,7 @@ bup split -vvvv -b testfile2 >tags2.tmp
bup split -t testfile2 >tags2t.tmp
bup split -t testfile2 --fanout 3 >tags2tf.tmp
bup split -r "$BUP_DIR" -c testfile2 >tags2c.tmp
+ls -lR | bup split -r "$BUP_DIR" -c --fanout 3 --max-pack-objects 3 -n lslr
diff -u tags1.tmp tags2.tmp || true
if diff -q tags2t.tmp tags2tf.tmp; then
echo "fanout tree same as non-fanout tree!?"

0 comments on commit 0f296c0

Please sign in to comment.