New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Silent failure during push due to IOError Broken Pipe #303

Open
reteptilian opened this Issue Jun 12, 2015 · 0 comments

Comments

Projects
None yet
1 participant
@reteptilian

reteptilian commented Jun 12, 2015

When pushing a large repo I get the following messages and then the command just returns without printing any error:

searching for changes
adding objects

Tracing in the debugger I see a IOError (32, 'Broken Pipe') being thrown somewhere in write_pack_objects(). (btw, as an aside, if you have any tips on how to get around this error that would be helpful).

It propagates all the way up to the giant dispatch.py:_runcatch method ... it goes into this block:

    except IOError, inst:
        ...
        elif util.safehasattr(inst, "args") and inst.args[0] == errno.EPIPE:
=>          if ui.debugflag:
                ui.warn(_("broken pipe\n"))

Since debugFlag is not set it just silently fails. I would argue this is a bug. It should fail noisily.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment