From 115e60bcab0a2cba27b137c61175493a347d0adc Mon Sep 17 00:00:00 2001 From: Tony Cook Date: Fri, 31 Aug 2012 00:43:19 +1000 Subject: [PATCH] [perl #112776] avoid warning on an initialized non-parameter A initialized non-parameter in the parameter block would warn when $^W was set, and Module::Build sets $^W. --- dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm | 4 ++-- dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Constants.pm | 2 +- dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/CountLines.pm | 2 +- dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Utilities.pm | 2 +- dist/ExtUtils-ParseXS/t/115-avoid-noise.t | 1 - 5 files changed, 5 insertions(+), 6 deletions(-) diff --git a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm index e211081bde9..d50b5010cd0 100644 --- a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm +++ b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS.pm @@ -11,7 +11,7 @@ use Symbol; our $VERSION; BEGIN { - $VERSION = '3.17'; + $VERSION = '3.18'; } use ExtUtils::ParseXS::Constants $VERSION; use ExtUtils::ParseXS::CountLines $VERSION; @@ -1768,7 +1768,7 @@ sub output_init { $argsref->{init}, $argsref->{printed_name} ); - my $arg = "ST(" . ($num - 1) . ")"; + my $arg = $num ? "ST(" . ($num - 1) . ")" : "/* not a parameter */"; if ( $init =~ /^=/ ) { if ($printed_name) { diff --git a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Constants.pm b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Constants.pm index 2f822dacbe9..2e27169aa22 100644 --- a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Constants.pm +++ b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Constants.pm @@ -3,7 +3,7 @@ use strict; use warnings; use Symbol; -our $VERSION = '3.16'; +our $VERSION = '3.18'; =head1 NAME diff --git a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/CountLines.pm b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/CountLines.pm index 66944cd629d..7e2a0f5030b 100644 --- a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/CountLines.pm +++ b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/CountLines.pm @@ -1,7 +1,7 @@ package ExtUtils::ParseXS::CountLines; use strict; -our $VERSION = '3.16'; +our $VERSION = '3.18'; our $SECTION_END_MARKER; diff --git a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Utilities.pm b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Utilities.pm index 0ae1eaed25b..d0089f8c009 100644 --- a/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Utilities.pm +++ b/dist/ExtUtils-ParseXS/lib/ExtUtils/ParseXS/Utilities.pm @@ -6,7 +6,7 @@ use File::Spec; use lib qw( lib ); use ExtUtils::ParseXS::Constants (); -our $VERSION = '3.17'; +our $VERSION = '3.18'; our (@ISA, @EXPORT_OK); @ISA = qw(Exporter); diff --git a/dist/ExtUtils-ParseXS/t/115-avoid-noise.t b/dist/ExtUtils-ParseXS/t/115-avoid-noise.t index 21febb2ab0b..2a99748affa 100644 --- a/dist/ExtUtils-ParseXS/t/115-avoid-noise.t +++ b/dist/ExtUtils-ParseXS/t/115-avoid-noise.t @@ -12,7 +12,6 @@ chdir 't' or die "Can't chdir to t/, $!"; # warning in that case. { - local $TODO = "Test for warning on non-parameter in parameter list"; my $out; open my $out_fh, ">", \$out; my @warnings;