Join GitHub today
GitHub is home to over 20 million developers working together to host and review code, manage projects, and build software together.
"showoff static" fails with error #117
Comments
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
davetron5000
Aug 23, 2011
Contributor
I'm having a hard time seeing how this ever worked; when I remove the verbose stuff, it just bombs on the next thing.
It seems like a big flaw in the design; the static stuff creates an instance of ShowOff just to get at the options hash, which is managed by Sinatra somehow. Your fix is probably the thing least likely to break something, but since there's no tests, I'd be afraid to do something more drastic.
I'm having a hard time seeing how this ever worked; when I remove the verbose stuff, it just bombs on the next thing. It seems like a big flaw in the design; the static stuff creates an instance of ShowOff just to get at the options hash, which is managed by Sinatra somehow. Your fix is probably the thing least likely to break something, but since there's no tests, I'd be afraid to do something more drastic. |
This comment has been minimized.
Show comment
Hide comment
This comment has been minimized.
Show comment Hide comment
badboy
Aug 23, 2011
Contributor
Yep, this is really flawed. I will definitely look into it tonight or tomorrow (exporting static versions is the thing I really need, so this bugs me).
Maybe I will have to rewrite the whole damn thing, let's se...
Yep, this is really flawed. I will definitely look into it tonight or tomorrow (exporting static versions is the thing I really need, so this bugs me). |
badboy commentedAug 23, 2011
When executing
showoff static
I get:This is due to line 46 in
lib/showoff.rb
.A quick fixed that works for me is adding "options" as an OpenStruct:
but this seems like a nasty hack. Any ideas how to handle this in a proper way?