Presenter display layout hosed on Firefox 9 and 10 #167

Open
durin42 opened this Issue Feb 14, 2012 · 25 comments

3 participants

@durin42

I did some cursory investigation, but I'm honestly not sure what's up with the layout. It appears to be some disagreement between Webkit and Gecko on how to render the slide div. Seeing this with ffox on OS X, but I'd imagine it happens on other platforms as well.

@goncalossilva goncalossilva added a commit that closed this issue Mar 6, 2012
@goncalossilva goncalossilva Fix #167. a92d2e4
@durin42

I'm not seeing this as entirely fixed - the div containing the presentation is still 1024x768 despite being visually scaled down by 50%. The net result is that the speaker notes are pushed off the bottom of my screen on my MacBook Air.

@goncalossilva
Collaborator

This is not a fix for the problem, but for the compatibility issues around FF. It's now using the same hack as in Chrome.

The presenter view definitely needs some love.

@durin42

Should I open a new issue reflecting the current state of the presenter view in ff?

@goncalossilva
Collaborator

Does the same issue (notes being pushed off) happen on Chrome/Safari? If yes, please open a new issue. If not, please reopen this one :-)

@durin42

It does not occur in Chrome or Safari. I don't have permission to reopen issues, so I can't do so.

@goncalossilva goncalossilva reopened this Mar 8, 2012
@goncalossilva
Collaborator

Thanks for digging this for me!

@bknowles

I also noticed problems in presenter mode on Firefox. Is there anything I can do to help debug this issue?

@goncalossilva
Collaborator

The same problems @durin42 mentioned?

@bknowles

I believe so. Do you want to see some screencaps?

@goncalossilva
Collaborator

That would be helpful. That and some CSS fu :p

@bknowles

Dunno that I can help with the CSS fu, but I can give you some screencaps. These come from doing a showoff presentation of my tutorial at https://github.com/bknowles/chef-fundamentals/tree/flossuk-EDI-2012 which I am preparing to present on the 20th of March in Edinburgh. It shows up okay in Chrome, so while I have other problems with showoff, this particular one isn't a show stopper for me right now.

Anyway, let me now go try to figure out how to upload the screencaps.

@durin42

Weird, that's not quite what I'm seeing with master. I'll try to post screenshots later today.

@goncalossilva
Collaborator

@bknowles are you sure you're testing off master? I committed a work-around to prevent some of your issues on FF: a92d2e4

@bknowles

No, I was testing off the released gem for showoff-0.7.0.

If you can give me some pointers on how to install the current "master" version with all associated dependencies, I'll be glad to re-do my tests and see what comes up.

@goncalossilva
Collaborator

Sure!

Edit your Gemfile and replace your showoff line with this one: gem "showoff", :git => "git://github.com/schacon/showoff.git"

Run bundle install and bundle exec showoff serve ;)

@bknowles

So, this is the relevant current contents of /usr/bin/showoff:

gem 'showoff', version
load Gem.bin_path('showoff', 'showoff', version)

Can I just replace these two lines with your one line? I'll try that, but I wanted to ask to be sure.

@goncalossilva
Collaborator

No, no! The file you need to edit is the Gemfile, located in the root of your presentation folder.

@bknowles

The only Gemfile that I have anywhere remotely close to my presentation folder is in the showoff subdirectory that was installed when I forked the showoff repository, so that I could upload my screencaps. I made sure to keep that subdirectory close to the directories where I was doing the presentations, so that I could try to keep all that related work together in my directory structure.

I've been running "showoff serve" manually from the command line, when I was in the appropriate /slides subdirectory of the presentation I was working on -- either from the subdirectory corresponding to https://github.com/bknowles/zero-to-cloud/tree/master/slides or from the subdirectory corresponding to https://github.com/bknowles/chef-fundamentals/tree/master/slides

@goncalossilva
Collaborator

Ok, one of your presentations has a Gemfile: https://github.com/bknowles/chef-fundamentals/blob/master/Gemfile

Just change the line I wrote before, run bundle install, and use bundle exec showoff serve.

@bknowles

Aw, crap. I completely missed that Gemfile. And I hadn't copied that over to my other project. Fixing that now.

Let me try the change and see if this fixes stuff, at least with regards to how I presume things should look when using the official version of showoff, instead of the fork that jtimberman created. ;-(

@bknowles

Okay, well this looks different with Firefox. New screencaps to be uploaded shortly.

@bknowles

Okay, it is still borked, but now it's borked in a somewhat different way. See https://github.com/bknowles/showoff/tree/issue-167/screencaps

@durin42
@goncalossilva
Collaborator

Yeah, it's pretty annoying. FF doesn't implement "zoom:" ATM. I'll try to think of a better work-around.

@rctay rctay pushed a commit to rctay/showoff that referenced this issue Jul 20, 2014
@durin42 durin42 presenter display: fix notes view on Firefox
Gecko doesn't seem to infer the reduced margin the same way WebKit
does, but explicitly stating the -50% margin works correctly on both
browsers.

Fixes schacon#167.
e91f698
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment