Add showoff:incr event for incrementing items on a slide. Fix gemspec loading issues #132

Merged
merged 4 commits into from Nov 17, 2011

Conversation

Projects
None yet
3 participants
Contributor

bgentry commented Sep 26, 2011

No description provided.

Owner

bgentry commented on b692a01 Sep 27, 2011

Initialliy I tried to put this in ShowOff::Version, but because ShowOff inherits from Sinatra::Application, it would not have fixed the gemspec load issue I was experiencing.

In the future it would make sense to have a module ShowOff as the toplevel namespace and then have a class ShowOff::App < Sinatra::Application or something along those lines. The current class structure also prevented me from doing ShowOff::Pusher::Version in my own addon gem.

will commented Sep 27, 2011

+1 for increment event

Contributor

bgentry commented Oct 12, 2011

anything I can do to help this get merged?

goncalossilva added a commit that referenced this pull request Nov 17, 2011

Merge pull request #132 from bgentry/master
Add showoff:incr event for incrementing items on a slide. Fix gemspec loading issues

@goncalossilva goncalossilva merged commit d8e5f0f into schacon:master Nov 17, 2011

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment