Make ShowOff compatible with Rack::URLMap #136

Merged
merged 1 commit into from Nov 17, 2011

Conversation

Projects
None yet
4 participants
Contributor

jcoglan commented Oct 1, 2011

If you try to mount a ShowOff deck under a path with Rack::URLMap, that paths to the assets are not correct. I've added @asset_path to a few places to make sure decks load correctly if you want to host multiple decks on one domain.

Contributor

rkh commented Oct 4, 2011

👍

@goncalossilva goncalossilva added a commit that referenced this pull request Nov 17, 2011

@goncalossilva goncalossilva Merge pull request #136 from jcoglan/master
Make ShowOff compatible with Rack::URLMap
7116e02

@goncalossilva goncalossilva merged commit 7116e02 into schacon:master Nov 17, 2011

Contributor

matschaffer commented on lib/showoff.rb in 950fc57 Jan 18, 2012

Something seems off here on ruby 1.9.2 and 0ea1df5. asset_path is coming out as an empty string and File.join('', 'a') is /a not ./a. What was this gsubbing supposed to do?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment