Templating + Fixes for Static and PDF Generation #149

Merged
merged 16 commits into from Mar 5, 2012

Conversation

Projects
None yet
3 participants
Contributor

grundprinzip commented Nov 13, 2011

Hi,

basically this group of commits does a few things.

First, it implements a way to provide the user with layout templates if he wants and make the pretty configurable . Templates can be applied either per default or per slide. Please have a look at the updated readme for a usage instruction.

Second, I fixed a a few bugs that relate to static HTML and PDF generation. This includes, rewriting URLs used in CSS to point to static file:// URIs, forcing wkthmltopdf to use the print media styles instead of the screen media styles. In addition sytnax highlighting now works both in PDF and static mode.

It would be great if you could review my changes.

You can find a simple presentation of how to use the templates, made with showoff here - http://grundprinzip.github.com/Showoff-Templates

Thanks
Martin

grundprinzip added some commits Nov 12, 2011

Fixing print CSS
When printing the CSS file paths need to be rewritten
to match the absolute URIs used in PDFKit. In addition, it
is required to configure the print media style or 
the output will be buggy. 

In print mode, the position of the slide needs to be 
set explicitly to "relavtive" or more explict styling 
in the slide container will fail in print mode.
Templates
* allow templates to be configurable
* allow default template to be not present
* parsing of slide options
Templates for Statics and PDFs
* fixing positioning of a slide when using the onepage.css
Documentation and Replacements
Replaced the ###CONTENT### string with something 
that does not break in Markdown :). Furthermore now
multiple replacements can be used in the slides, the 
documentation is in the README.
Contributor

grundprinzip commented Nov 14, 2011

This would close #143 and #144 as well.

@grundprinzip grundprinzip referenced this pull request Nov 14, 2011

Closed

Giant Merge #150

Contributor

grundprinzip commented Nov 18, 2011

I merged the recent changes from schacon/master to keep the changes compatible with the current development.

Hey, this is just what I was looking for! I hope this gets merged in soon.

Collaborator

goncalossilva commented Mar 5, 2012

I love this change. I'm not so sure about the ~~~ SYNTAX ~~~, but I don't have a better suggestion either.

I'll merge this and tweak the README a little bit. This is an advanced feature and I believe it's introduced too soon.

goncalossilva added a commit that referenced this pull request Mar 5, 2012

Merge pull request #149 from grundprinzip/templating
Templating + Fixes for Static and PDF Generation

@goncalossilva goncalossilva merged commit 580c025 into schacon:master Mar 5, 2012

goncalossilva added a commit that referenced this pull request Mar 5, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment