Skip to content

HTTPS clone URL

Subversion checkout URL

You can clone with
or
.
Download ZIP

Loading…

move to the next slide when clicking - closes #141 #168

Closed
wants to merge 1 commit into from

2 participants

@dmathieu

This allows the use of remote mouse

@goncalossilva
Collaborator

Hello,

I like this, but this change introduces a bug. Showoff supports executable code blocks which, when clicked, will run the code and output the result. This change, as it is, produces strange results with those blocks: an overlay is displayed with the execution result, but the slide has changed as well.

I can think of 2 ways of implementing this:

  • As it is, but forcing all element click events to stopPropagation() if it was not supposed to change the slide (our click events and all user generated click events, which sucks);
  • Create a method which will only advance the slide if no click handler was triggered until then. If the user wants to advance the slide, he must additionally call our API function to achieve that.

I like the second approach better. It's more "presentation software" style, and involves no additional effort from showoff users.

What do you think? @schacon, want to weigh in on this?

@goncalossilva goncalossilva referenced this pull request from a commit
Commit has since been removed from the repository and is no longer available.
@dmathieu dmathieu closed this
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Commits on Feb 15, 2012
  1. @dmathieu
This page is out of date. Refresh to see the latest.
Showing with 1 addition and 0 deletions.
  1. +1 −0  public/js/showoff.js
View
1  public/js/showoff.js
@@ -37,6 +37,7 @@ function setupPreso(load_slides, prefix) {
// bind event handlers
document.onkeydown = keyDown
document.onkeyup = keyUp
+ document.onclick = nextStep
/* window.onresize = resized; */
/* window.onscroll = scrolled; */
/* window.onunload = unloaded; */
Something went wrong with that request. Please try again.