presenter view: give the spawned slides window the ability to move our location #169

Merged
merged 1 commit into from Mar 6, 2012

Projects

None yet

2 participants

@durin42
Contributor
durin42 commented Mar 2, 2012

This means that you can open the presenter view and have it spawn a
slides window, but then make the slides window fullscreen instead of
the presenter view (which can be a background window on another
display). I didn't test it very much, but it seems to work well enough.

I'm not terribly happy with how this looks, but it seemed like it might be desirable anyway.

@durin42 durin42 presenter view: give the spawned slides window the ability to move ou…
…r location

This means that you can open the presenter view and have it spawn a
slides window, but then make the slides window fullscreen instead of
the presenter view (which can be a background window on another
display). I didn't test it very much, but it seems to work well enough.

This uses the horrible hack of setting an attribute on the slide
window because otherwise the reference back to the parent window was
sometimes (but not always) getting clobbered when showoff.js loaded in
the child window.
d8c7afd
@goncalossilva
Collaborator

Hello,

Thank you for this! However, I couldn't really understand or see what it does. Could you please explain it with a bit more detail?

Thanks!

@durin42
Contributor
durin42 commented Mar 5, 2012

Normally when you visit the presenter view, you have to advance slides only from the presenter view. If you do anything on the presentation (slides-only) view, things get out of sync and it's really frustrating. Furthermore, if you make the slides fullscreen, you can't actually send the keystrokes needed to the presenter view. This fixes both of those issues.

@durin42
Contributor
durin42 commented Mar 5, 2012

(Let me know if I'm answering the wrong question here - I assumed the functionality I'm adding is nonobvious.)

@goncalossilva goncalossilva merged commit 711f41c into schacon:master Mar 6, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment