Fix for presenter view on Firefox (issue 167) #207

Merged
merged 2 commits into from Mar 12, 2013

Projects

None yet

2 participants

@durin42
durin42 commented Mar 5, 2013

Also includes a second commit to clean up some trailing whitespace. Not passionate about that one, feel free to drop it if you don't want that change.

durin42 added some commits Mar 5, 2013
@durin42 durin42 presenter display: fix notes view on Firefox
Gecko doesn't seem to infer the reduced margin the same way WebKit
does, but explicitly stating the -50% margin works correctly on both
browsers.

Fixes #167.
e91f698
@durin42 durin42 presenter css: remove trailing whitespace e89361c
@goncalossilva
Collaborator

Doesn't this cause issues with other browsers? I'm asking naively, I didn't test it.

@durin42
durin42 commented Mar 6, 2013

I tested Safari, Chrome, and Firefox. They all looked reasonable.

@durin42
durin42 commented Mar 6, 2013

That said, feel encouraged to check my work before merging. I'd hate for it to be a "works on my machine" situation.

@durin42
durin42 commented Mar 12, 2013

So, presenter view still looks good in Chrome and Safari, as well as (now) FireFox.

@goncalossilva goncalossilva merged commit d297bd2 into schacon:master Mar 12, 2013
@goncalossilva
Collaborator

Finally got around to checking it out. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment