presenter view: respect starting slide from URL #208

Merged
merged 1 commit into from Jul 29, 2013

Conversation

Projects
None yet
3 participants
Contributor

durin42 commented Mar 12, 2013

We didn't correctly pass the hash fragment of the location to the
spawned slides window, which caused the presenter view to always start
at slide 1, even if it was refreshed during slide development
someplace else in the slide deck. This corrects that defect.

presenter view: respect starting slide from URL
We didn't correctly pass the hash fragment of the location to the
spawned slides window, which caused the presenter view to always start
at slide 1, even if it was refreshed during slide development
someplace else in the slide deck. This corrects that defect.
Contributor

durin42 commented Apr 10, 2013

Friendly ping. This worked great for me in my presentation at PyCon.

Collaborator

rctay commented Jul 28, 2013

@goncalossilva This looks correct. Appending the hash part at the end is what w3 specifies [1]. Using window.location.hash is also safe, because it is either a) an empty string, or b) a string prefixed with '#' [2].

[1] https://dvcs.w3.org/hg/url/raw-file/tip/Overview.html#serializing
[2] https://dvcs.w3.org/hg/url/raw-file/tip/Overview.html#dom-url-hash

Collaborator

goncalossilva commented Jul 29, 2013

Thanks guys!

goncalossilva added a commit that referenced this pull request Jul 29, 2013

Merge pull request #208 from durin42/presenter-view-respect-start-param
presenter view: respect starting slide from URL

@goncalossilva goncalossilva merged commit 0e71227 into schacon:master Jul 29, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment