Skip to content

Support for migration runner using DotConnect for Oracle driver from Devart #288

Merged
merged 1 commit into from Nov 10, 2012

4 participants

@daniellee
Collaborator

Thanks for this pull request. I was hoping one of our committers that knows something about Oracle would have a look at this. Anyone? @swalters maybe?

@swalters
Collaborator

I be glad to review before the week is over. Too busy for the first of this week.

@daniellee
Collaborator

Anything happening with reviewing this?

@daniellee
Collaborator

Sorry @robertmircea I'm really not an Oracle guy. Anyone (who uses Oracle) have time to review this?

By the way, it would be great if you could add tests. I know that are nearly no tests for the Oracle stuff so it would improve that area of FluentMigrator a lot.

@robertmircea

DotConnect for Oracle is very compatible with ODP.NET (official Oracle driver). The code is essentially the same as the one using ODP.NET (already in the framework). The difference is related to the instantiation of the proper processor (DotConnectOracleProcessor). A quick, mechanical review would be to compare the two implementations. Anyway, I'll hope that someone in the near future will have time to review it. If the code cannot be accepted in the main base, a compromise might be to make a separate nuget package from an external repo: e.g. fluentmigrator.dotconnectoracle for example.

@tommarien
Collaborator

I'll try to pull it in this weekend, i am not an Oracle guy, but as I see this commit I don't see any harm in pulling this in. I am sure that this is allready a good start and if problems arise they can be tackled then :)

@tommarien tommarien merged commit b9f4cda into schambers:master Nov 10, 2012
@tommarien
Collaborator

@robertmircea i just pulled the request, only corrected a namespace mismatch thx and sorry for the delay ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Something went wrong with that request. Please try again.