Skip to content
Permalink
Branch: benchmarks
Commits on Jun 9, 2019
  1. Add two benchmarks based on the functional tests suite

    schancel committed Jun 9, 2019
    * big_block_test.py - Mines blocks up to a specified size, and
     aggregates the associated data
    * chained_transactions - Mines a single long chain of transactions
     up to a specified length. Also outputs the associated data as json
Commits on Jun 6, 2019
  1. Merge #12904: [qa] Ensure bitcoind processes are cleaned up when test…

    laanwj authored and Nico Guiton committed Apr 8, 2018
    …s end
    
    Summary:
    e36a0c0 [qa] Ensure bitcoind processes are cleaned up when tests end (Suhas Daftuar)
    
    Pull request description:
    
      When tests fail (such as due to a bug in the test, race condition, etc), it's possible that we could follow code paths that bypass our normal node shutdown that occurs in `TestNode.stop_node`.  Add a destructor to `TestNode` that cleans this up.
    
    Tree-SHA512: 72e04bc21462ebd0cb346fd1fe0540da454acfbad41923a0b06ea2317e9045b68e58f9adb02d8200891aca89a9d03a022eb72282aeb31a3b3afe7c6843a4b450
    
    Backport of Core PR12904
    bitcoin/bitcoin#12904
    
    Depends on D3234
    
    Completes T446
    
    Test Plan:
      make check
      test_runner.py
    
    Reviewers: jasonbcox, deadalnix, Fabien, O1 Bitcoin ABC, #bitcoin_abc
    
    Reviewed By: jasonbcox, deadalnix, O1 Bitcoin ABC, #bitcoin_abc
    
    Differential Revision: https://reviews.bitcoinabc.org/D3235
  2. Merge #10514: Bugfix: missing == 0 after randrange

    laanwj authored and Nico Guiton committed Jun 5, 2017
    Summary:
    9aa215b Bugfixes: missing == 0 after randrange (Pieter Wuille)
    
    Tree-SHA512: 160657ac09553f23ad7a3966c753a30ba938ce6f7ccfd34a4ef0d05d73d712362f7eef97e44a96e37a181b8347caa9d8e1584cc4485f69674ab2de3d8a247373
    
    Backport of Core PR10514
    bitcoin/bitcoin#10514
    
    Test Plan:
      make check
    
    Reviewers: jasonbcox, deadalnix, Fabien, O1 Bitcoin ABC, #bitcoin_abc
    
    Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc
    
    Differential Revision: https://reviews.bitcoinabc.org/D3240
  3. Merge #10500: Avoid CWalletTx copies in GetAddressBalances and GetAdd…

    sipa authored and Nico Guiton committed Jun 2, 2017
    …ressGroupings
    
    Summary:
    b9b814a Avoid CWalletTx copies in GetAddressBalances and GetAddressGroupings (Russell Yanofsky)
    
    Tree-SHA512: 96a0612ca460ba1bfb3921f3aa348400fd3afa12c40f2ca1f3f04068b1574fe824d577e0123013d8898a4990084316dc1dfb541331849f0996ceff7f4eb25e6b
    
    Backport of Core PR10500
    bitcoin/bitcoin#10500
    
    Test Plan:
      make check
      test_runner.py
    
    Reviewers: jasonbcox, Fabien, deadalnix, O1 Bitcoin ABC, #bitcoin_abc
    
    Reviewed By: jasonbcox, O1 Bitcoin ABC, #bitcoin_abc
    
    Differential Revision: https://reviews.bitcoinabc.org/D3239
  4. Merge #10469: Fixing typo in rpcdump.cpp

    laanwj authored and Nico Guiton committed Jun 1, 2017
    Summary:
    16d94d3 Fixing typo in rpcdump.cpp (James Evans)
    
    Tree-SHA512: 84ef1b91c719131196ebed6b865e282b77bee7699614e15884ba59010239a3bbc1380dc8f856c83338f071e3eb3ca41c6b10f830816e6c794531cf6a965d63a9
    
    Backport of Core PR10469
    bitcoin/bitcoin#10469
    
    Test Plan:
      make check
      test_runner.py
    
    Reviewers: jasonbcox, deadalnix, Fabien, O1 Bitcoin ABC, #bitcoin_abc
    
    Reviewed By: deadalnix, O1 Bitcoin ABC, #bitcoin_abc
    
    Differential Revision: https://reviews.bitcoinabc.org/D3238
  5. Rework the wallet fees interface to make it closer to core's

    deadalnix committed Jun 6, 2019
    Summary: All of this was fubared for no good reason.
    
    Test Plan:
      make check
    
    Reviewers: #bitcoin_abc, jasonbcox
    
    Reviewed By: #bitcoin_abc, jasonbcox
    
    Subscribers: jasonbcox
    
    Differential Revision: https://reviews.bitcoinabc.org/D3233
  6. Merge #9977: QA: getblocktemplate_longpoll.py should always use >0 fe…

    MarcoFalke authored and jasonbcox committed Mar 14, 2017
    …e tx
    
    Summary:
    655df06 QA: getblocktemplate_longpoll.py should always use >0 fee tx (Suhas Daftuar)
    
    Tree-SHA512: 016647ba1408f8aaa3fc954835542354d54bf2391c4252c1c505101edbbe1cf8dd6a07060930109d0341f86360b9391dfef439999a93a5bae68fc901dace0b71
    
    Backport of Core PR9977
    https://github.com/bitcoin/bitcoin/pull/9977/files
    
    Test Plan:
    ```
    test_runner.py mining_getblocktemplate_longpoll
    ```
    
    Reviewers: #bitcoin_abc, deadalnix, Fabien
    
    Reviewed By: #bitcoin_abc, Fabien
    
    Differential Revision: https://reviews.bitcoinabc.org/D3218
  7. Merge #10911: [qt] Fix typo and access key in optionsdialog.ui

    jonasschnelli authored and jasonbcox committed Sep 7, 2017
    Summary:
    d2be7b2 Typo in optionsdialog.ui Tooltip displayed ampersand incorrectly, & should be in text. (James Evans)
    
    Pull request description:
    
      Tooltip displayed ampersand incorrectly, & should be in text property rather than tooltip so that access key is correctly displayed for accessibility.
    
    Tree-SHA512: 331848207317d37d4d9db40119d0b7ae9a276d06cd1b057cd0e87d508e1aa769b785246ca30ca9156db632798ec9f68ba8bf78cf42904267b4187bd27cfced35
    
    Backport of Core PR10911
    https://github.com/bitcoin/bitcoin/pull/10911/files
    
    Test Plan:
    ```
    # on master
    bitcoin-qt
    # See that the text strings in this diff do not have their accessibility key underlined.
    # See that Settings -> Options -> Window, hovering over "Hide tray icon" has an errant ampersand.
    
    # with this patch applied
    make check
    bitcoin-qt
    # See that the text strings now have their accessibility keys underlined.
    # See that the errant ampersand is now gone.
    ```
    
    Reviewers: #bitcoin_abc, deadalnix, Fabien
    
    Reviewed By: #bitcoin_abc, Fabien
    
    Differential Revision: https://reviews.bitcoinabc.org/D3221
  8. remove four duplicate tests from script_tests.json

    markblundeberg committed Jun 6, 2019
    Summary:
    These are identical to the preceding four test cases.
    For the curious: they were introduced like this in 2014 by Peter Todd:
    bitcoin/bitcoin#3860
    
    Test Plan: `make check`
    
    Reviewers: jasonbcox, Fabien, #bitcoin_abc, deadalnix
    
    Reviewed By: jasonbcox, #bitcoin_abc
    
    Differential Revision: https://reviews.bitcoinabc.org/D3237
  9. Merge #10679: Document the non-DER-conformance of one test in tx_vali…

    laanwj authored and jasonbcox committed Aug 23, 2017
    …d.json.
    
    Summary:
    ecb11f5 Document the non-strict-DER-conformance of one test in tx_valid.json. (Andreas Schildbach)
    
    Tree-SHA512: 4d5ba4645fbfe8fe3f1baaa5f1a1152cdd2cbf3d901f38d8e7fbd56b16caa6a8a17f2a48c74fb725ce454dd1c870b81b2238e89d0639fcd4eee858554726e996
    
    Backport of Core PR10679
    https://github.com/bitcoin/bitcoin/pull/10679/files
    
    Test Plan: `make check`
    
    Reviewers: #bitcoin_abc, deadalnix, Fabien
    
    Reviewed By: #bitcoin_abc, Fabien
    
    Subscribers: Fabien
    
    Differential Revision: https://reviews.bitcoinabc.org/D3222
  10. Merge #11435: build: Make "make clean" remove all files created when …

    laanwj authored and jasonbcox committed Oct 4, 2017
    …running "make check"
    
    Summary:
    f35d033 build: Make "make clean" remove all files created when running "make check" (practicalswift)
    
    Pull request description:
    
      Make `make clean` remove all files created when running `make check`. More specifically: remove also `obj/build.h` and `bench/data/block413567.raw.h` as part of `make clean`.
    
      Before this patch:
    
      ```bash
      $ git clone https://github.com/bitcoin/bitcoin.git
      $ cd bitcoin/
      $ ./autogen.sh
      $ ./configure
      $ cp -r ../bitcoin ../bitcoin-before-make
      $ make check
      $ make clean
      $ cp -r ../bitcoin ../bitcoin-after-make-and-make-clean
      $ cd ..
      $ diff -rq bitcoin-before-make/ bitcoin-after-make-and-make-clean/ | grep -E "^Only in bitcoin-after-make-and-make-clean/" | grep -v dirstamp
      Only in bitcoin-after-make-and-make-clean/src/bench/data: block413567.raw.h
      Only in bitcoin-after-make-and-make-clean/src/obj: build.h
      $
      ```
    
      After this patch:
    
      ```bash
      $ git clone https://github.com/bitcoin/bitcoin.git
      $ cd bitcoin/
      $ ./autogen.sh
      $ ./configure
      $ cp -r ../bitcoin ../bitcoin-before-make
      $ make check
      $ make clean
      $ cp -r ../bitcoin ../bitcoin-after-make-and-make-clean
      $ cd ..
      $ diff -rq bitcoin-before-make/ bitcoin-after-make-and-make-clean/ | grep -E "^Only in bitcoin-after-make-and-make-clean/" | grep -v dirstamp
      $
      ```
    
    Tree-SHA512: 953e8423485ffd415f0ade6abe0b4c407454f67c332140ef019d89db425bb4a831327b3f634b8d69b17325dcfc6e3ac72dc2ba1ce5462158eecc3c05645e93ba
    
    Backport of Core PR11435
    https://github.com/bitcoin/bitcoin/pull/11435/files
    
    Test Plan:
    ```
    # on master
    make
    make clean
    ls src/bench/data
    # block413567.raw.h
    ls src/obj
    # build.h
    
    # with this patch applied
    make
    make clean
    ls src/bench/data
    # <nothing>
    ls src/obj
    # <nothing>
    ```
    
    Reviewers: #bitcoin_abc, deadalnix, Fabien
    
    Reviewed By: #bitcoin_abc, Fabien
    
    Differential Revision: https://reviews.bitcoinabc.org/D3223
  11. Merge #12877: doc: Use bitcoind in Tor documentation

    laanwj authored and jasonbcox committed Apr 5, 2018
    Summary:
    a5263fb doc: Use bitcoind in Tor documentation (Indospace.io)
    
    Pull request description:
    
    Tree-SHA512: 9440bb4dc3d4e43332d7e10bbba2fc88ce74f69c17777f5448556d5b0d572e3095fc284c80ba5669e02fa64c5f2fc2b911cc53c33cb67c44334afc405f2b77ba
    
    Backport of Core PR12877
    https://github.com/bitcoin/bitcoin/pull/12877/files
    
    Test Plan: Read it.
    
    Reviewers: #bitcoin_abc, deadalnix, Fabien
    
    Reviewed By: #bitcoin_abc, Fabien
    
    Differential Revision: https://reviews.bitcoinabc.org/D3224
  12. Merge #11620: [build] .gitignore: add background.tiff

    MarcoFalke authored and jasonbcox committed Nov 7, 2017
    Summary:
    4a110a0 [build] .gitignore: add background.tiff (Sjors Provoost)
    
    Pull request description:
    
      On OSX, running `make deploy` results in three files that were not covered by `.gitignore`:
    
      	background.tiff
      	background.tiff.png
      	background.tiff@2x.png
    
    Tree-SHA512: cee7a6ebbc50f28bf588121902f6026ec08cf6516d9e56734dfc1b2d3f238e2db5bf87411f6a74b8bd06569f792789ac9f9046e6183f63fd675b953f24b060fc
    
    Backport of Core PR11620
    https://github.com/bitcoin/bitcoin/pull/11620/files
    
    Test Plan:
    I don't have a Mac to test `make deploy` on, but next best thing:
    ```
    touch background.tiff
    touch background.tiff.png
    git status
    # shows no background.tiff* files
    ```
    
    Reviewers: #bitcoin_abc, deadalnix, Fabien
    
    Reviewed By: #bitcoin_abc, Fabien
    
    Subscribers: Fabien
    
    Differential Revision: https://reviews.bitcoinabc.org/D3226
  13. Merge #11380: Remove outdated share/certs/ directory

    laanwj authored and jasonbcox committed Sep 22, 2017
    Summary:
    6951a1c Remove extremely outdated share/certs dir (MeshCollider)
    
    Pull request description:
    
      The directory hasn't been touched for 5 years (other than a couple of typo fixes/renaming). The certificates are expired, the build process notes are out of date, especially with the gitian building and everything, Gavin no longer has anything to do with it, etc.
    
      The signing process is all documented (and scripted) elsewhere (e.g. doc/release-process.md and gitian-building.md, contrib/macdeploy and windeploy), this can just be removed
    
      @theuni can confirm if this is okay, we discussed it on IRC for a bit :)
    
    Tree-SHA512: e229785f7514a0f9988105f2ce68531a0a876032983ee5c77f41f1a976b9e732eb63cf2eb1f82841df8f7194940635c5ea5d4f8b30f95e69c763f74d4a3a28b1
    
    Backport of Core PR11380
    https://github.com/bitcoin/bitcoin/pull/11380/files
    
    Test Plan: N/A
    
    Reviewers: #bitcoin_abc, deadalnix, Fabien
    
    Reviewed By: #bitcoin_abc, Fabien
    
    Differential Revision: https://reviews.bitcoinabc.org/D3227
  14. Merge #12843: [tests] Test starting bitcoind with -h and -version

    MarcoFalke authored and Nico Guiton committed Apr 1, 2018
    Summary:
    63048ec [tests] Test starting bitcoind with -h and -version (John Newbery)
    
    Pull request description:
    
      Test that starting bitcoind/bitcoin-qt with `-h` and `-version` works as expected.
    
      Prompted by bitcoin/bitcoin#10762 (comment), which is a nullpointer dereference triggered by starting bitcoin-qt with `-h`.
    
      On master, this test passes when run over bitcoind, but fails when running over bitcoin-qt. I used xvfb as a virtual frame buffer to test:
    
      ```
      BITCOIND=/home/ubuntu/bitcoin/src/qt/bitcoin-qt xvfb-run ./feature_help.py --nocleanup
      2018-03-30T17:09:37.767000Z TestFramework (INFO): Initializing test directory /tmp/user/1000/testdi4dre13
      2018-03-30T17:09:37.767000Z TestFramework (INFO): Start bitcoin with -h for help text
      2018-03-30T17:09:37.841000Z TestFramework (ERROR): Assertion failed
      Traceback (most recent call last):
        File "/home/ubuntu/bitcoin/test/functional/test_framework/test_framework.py", line 126, in main
          self.run_test()
        File "./feature_help.py", line 25, in run_test
          assert_equal(ret_code, 0)
        File "/home/ubuntu/bitcoin/test/functional/test_framework/util.py", line 39, in assert_equal
          raise AssertionError("not(%s)" % " == ".join(str(arg) for arg in (thing1, thing2) + args))
      AssertionError: not(-11 == 0)
      2018-03-30T17:09:37.842000Z TestFramework (INFO): Stopping nodes
      Traceback (most recent call last):
        File "./feature_help.py", line 42, in <module>
          HelpTest().main()
        File "/home/ubuntu/bitcoin/test/functional/test_framework/test_framework.py", line 149, in main
          self.stop_nodes()
        File "/home/ubuntu/bitcoin/test/functional/test_framework/test_framework.py", line 273, in stop_nodes
          node.stop_node()
        File "/home/ubuntu/bitcoin/test/functional/test_framework/test_node.py", line 141, in stop_node
          self.stop()
        File "/home/ubuntu/bitcoin/test/functional/test_framework/test_node.py", line 87, in __getattr__
          assert self.rpc_connected and self.rpc is not None, "Error: no RPC connection"
      AssertionError: Error: no RPC connection
      ```
    
      Passes for bitcoind and bitcoin-qt when run on #12836.
    
      Longer term, we should consider running functional tests over bitcoin-qt in one of the Travis jobs.
    
    Tree-SHA512: 0c2f40f3d5f0e78c3a1b07dbee8fd383eebab27ed0bf2a98a5b9cc66613dbd7b70e363c56163a37e02f68ae7ff7b3ae1769705d0e110ca68a00f8693315730a4
    
    Backport of Core PR12843
    bitcoin/bitcoin#12843
    
    Completes T569
    
    Test Plan:
      test_runner.py should also run the feature_help.py test and pass
      test_runner.py feature_help should run and pass
    
    Reviewers: jasonbcox, deadalnix, Fabien, O1 Bitcoin ABC, #bitcoin_abc
    
    Reviewed By: jasonbcox, Fabien, O1 Bitcoin ABC, #bitcoin_abc
    
    Differential Revision: https://reviews.bitcoinabc.org/D3234
  15. Merge #10961: Improve readability of DecodeBase58Check(...)

    laanwj authored and jasonbcox committed Oct 9, 2017
    Summary:
    c6a995e Improve readability of DecodeBase58Check(...) (practicalswift)
    
    Pull request description:
    
      Use the more readable form ...
    
      ```c++
      &vchRet[vchRet.size() - 4]
      ```
    
      ... instead of ...
    
      ```c++
      &v.end()[-n]
      ```
    
      Has the added benefit of eliminating a spurious static analyzer warning about improper use of negative values.
    
    Tree-SHA512: 5895310c189e9322082c28f34342ff9a6c238e2cae3f204521111c8a7981bc555af60b42de082c91608c1125dfc244a65c4faf929249a067a51435e2be74cb39
    
    Backport of Core PR10961
    https://github.com/bitcoin/bitcoin/pull/10961/files
    
    Test Plan: `make check`
    
    Reviewers: #bitcoin_abc, deadalnix, Fabien
    
    Reviewed By: #bitcoin_abc, Fabien
    
    Differential Revision: https://reviews.bitcoinabc.org/D3228
  16. Merge #10464: Introduce static DoWarning (simplify UpdateTip)

    sipa authored and Nico Guiton committed May 30, 2017
    Summary:
    f285145 Introduce static DoWarning (simplify UpdateTip) (Jorge Timón)
    
    Tree-SHA512: 58b39f00bc921d47d199ef1cc15e9e36f918ec86e9182de46dc2f24fa9474853a92b18d330a274a3ea7c9b001681fdfa3d86aa2bbebb5c92ac8c5a6f7690dfc1
    
    Backport of Core PR10464
    bitcoin/bitcoin#10464
    
    Test Plan:
      make check
      test_runner.py
    
    Reviewers: jasonbcox, deadalnix, Fabien, markblundeberg, O1 Bitcoin ABC, #bitcoin_abc
    
    Reviewed By: jasonbcox, markblundeberg, O1 Bitcoin ABC, #bitcoin_abc
    
    Differential Revision: https://reviews.bitcoinabc.org/D3230
  17. Avoid spurious boost output in scheduler_tests

    Fabcien committed Jun 6, 2019
    Summary:
    Boost test macros try to output some message, which leads to a messy
    debug output when called in intricated threads.
    Use `assert` in these cases solves the issue.
    
    Backport of Core PR14069
    https://github.com/bitcoin/bitcoin/pull/14069/files
    
    Test Plan:
      ./src/test/test_bitcoin -t scheduler_tests
    Without the patch it will sometime output partial boost debug info.
    With the patch the output will remain clean.
    
    Reviewers: #bitcoin_abc, deadalnix, jasonbcox
    
    Reviewed By: #bitcoin_abc, jasonbcox
    
    Subscribers: jasonbcox
    
    Differential Revision: https://reviews.bitcoinabc.org/D3232
  18. Merge #11710: cli: Reject arguments to -getinfo

    laanwj authored and Nico Guiton committed Nov 18, 2017
    Summary:
    dcfef27 cli: Reject arguments to -getinfo (Wladimir J. van der Laan)
    
    Pull request description:
    
      Currently it's possible to accidentally type e.g.
    
          bitcoin-cli -getinfo getbalance
    
      and get an answer which can be confusing; the trailing arguments are just ignored.
    
      To avoid this, throw an error if the user provides arguments to
      `-getinfo`.
    
    Tree-SHA512: 3603e8fa852b884d1dd3b7462db40b092fe8b3390fd4384b4ee330315d797aff711e9f62990012fd4b5a55c8678734ba8497a5488a09ee6b65cf8a99017d6eb4
    
    Backport of Core PR11710
    bitcoin/bitcoin#11710
    
    Please note, this is `./bitcoin-cli -getinfo`, NOT the deprecated/removed RPC call.
    
    Test Plan:
      make check
      test_runner.py
    
    Reviewers: jasonbcox, deadalnix, Fabien, O1 Bitcoin ABC, #bitcoin_abc, markblundeberg
    
    Reviewed By: O1 Bitcoin ABC, #bitcoin_abc, markblundeberg
    
    Subscribers: markblundeberg
    
    Differential Revision: https://reviews.bitcoinabc.org/D3229
  19. Fix a bunch of spelling errors

    Fabcien committed Jun 5, 2019
    Summary: As per title.
    
    Test Plan:
      make check
      ./test/functional/test_runner.py
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3216
Commits on Jun 5, 2019
  1. Remove unused function for fees.h exposed interface

    deadalnix committed Jun 5, 2019
    Summary: As pe title.
    
    Test Plan:
      make check
    
    Reviewers: #bitcoin_abc, jasonbcox
    
    Reviewed By: #bitcoin_abc, jasonbcox
    
    Differential Revision: https://reviews.bitcoinabc.org/D3214
  2. Clean up Segwit Recovery feature

    Mengerian committed May 21, 2019
    Summary:
    Invert meaning of Segwit Recovery flag.
    Remove segwit recovery activation
    Make SCRIPT_DISALLOW_SEGWIT_RECOVERY a standard flag
    
    Test Plan:
    make check
    Did IBD on main net and testnet with `checkpoints=0 -assumevalid=0`.
    Update functional test to check for accepting blocks containing segwit recovery transactions,
    rejecting segwit recovery transactions from mempool acceptance, and correct network banning.
    
    Reviewers: deadalnix, #bitcoin_abc, markblundeberg, Fabien, jasonbcox
    
    Reviewed By: deadalnix, #bitcoin_abc, markblundeberg
    
    Subscribers: markblundeberg
    
    Maniphest Tasks: T653
    
    Differential Revision: https://reviews.bitcoinabc.org/D3194
  3. Merge #11884: Remove unused include in hash.cpp

    laanwj authored and jasonbcox committed Dec 14, 2017
    Summary:
    3f09e03 Remove unused include in hash.cpp (Karl-Johan Alm)
    
    Pull request description:
    
    Tree-SHA512: 543a72656460fba1c5498a0b85c49601d9b0399a4ecc49f4acf4715c258918da729df388e3be724c3161438e903ee16ad3c50626a71483aa6d85ffdbb827742d
    
    Backport Core PR11884
    https://github.com/bitcoin/bitcoin/pull/11884/files
    
    Test Plan: `make check`
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3208
  4. Merge #12434: [doc] dev-notes: Members should be initialized

    laanwj authored and jasonbcox committed Mar 5, 2018
    Summary:
    fa94614 [doc] dev-notes: Members should be initialized (MarcoFalke)
    
    Pull request description:
    
      Also, remove mention of threads that were removed long ago.
    
      Motivation:
      Make it easier to spot bugs such as #11654 and  #12426
    
    Tree-SHA512: 8ca1cb54e830e9368803bd98a8b08c39bf2d46f079094ed7e070b32ae15a6e611ce98d7a614f897803309f4728575e6bc9357fab1157c53d2536417eb8271653
    
    Partial (mostly) backport of Core PR12434
    https://github.com/bitcoin/bitcoin/pull/12434/files
    
    This diff brings this section of the developer-notes up-to-date with recent backporting efforts (~mid 2018) but retains the -Wshadow documentation applicable to ABC.
    It includes some documentation additions from https://github.com/bitcoin/bitcoin/pull/8794/files#diff-e4de6d71249c78e229a61d6a03ac255a
    and skips backporting MarcoFalke/bitcoin@f203ecc
    
    Test Plan:
    `make`
    Read it.
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3207
  5. Merge #12501: [qt] Improved "custom fee" explanation in tooltip

    laanwj authored and jasonbcox committed Mar 5, 2018
    Summary:
    0bc095e [qt] Improved "custom fee" explanation in tooltip (Randolf Richardson)
    
    Pull request description:
    
      Thanks to @dooglus for asking about this tooltip in Issue 12500.
      Reference:  https://www.github.com/bitcoin/bitcoin/issues/12500
    
      I would also appreciate it if someone can confirm that 1 kilobyte in this field indeed represents 1,000 bytes rather than 1,024 bytes (if it's supposed to be 1,024, then I'll gladly make the necessary changes to reflect this).
    
    Tree-SHA512: da2fe0128411b5ef6f0a26382a80601efcf823c3f3591bdd83a7fe7e25777728e7eb89e2e8b175b991566e63838aca12d204792f981031b86e7b2ba28ca50021
    
    Backport of Core PR12501
    https://github.com/bitcoin/bitcoin/pull/12501/files
    
    Test Plan:
    ```
    make check
    bitcoin-qt
    # Hover over the 'per Kilobyte' note to see the updated tooltip
    ```
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3206
  6. Merge #12584: Fix typos and cleanup documentation

    MarcoFalke authored and jasonbcox committed Mar 3, 2018
    Summary:
    a9761ca Fix typos and cleanup (Dimitris Apostolou)
    
    Pull request description:
    
      [ci-skip]
    
    Tree-SHA512: 6d7e02d8fdf6add702bbfe4439ace9c8621b45d21111abc69d85be9120347b06a029bc1885665547c1230ebc41da9d97210f6d1325b7692a4585356969ecb127
    
    Backport of Core PR12584
    https://github.com/bitcoin/bitcoin/pull/12584/files
    
    Test Plan: Read it.
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3204
  7. Merge #12999: qt: Show the Window when double clicking the taskbar icon

    laanwj authored and jasonbcox committed Apr 23, 2018
    Summary:
    67bf2aa qt:Show the entire Window when double clicking on taskbar (Chun Kuan Lee)
    
    Pull request description:
    
      fix #12838
    
    Tree-SHA512: 4498bc1fe52efeed3768d6bdd7941e4b036d52ae80d9c1b6679c6daa3a62aeda4cff0c91fe1c65afaea6049c59cb0296fdcbff63ecb342d518615a92361fda7f
    
    Backport Core PR12999
    https://github.com/bitcoin/bitcoin/pull/12999/files
    
    Test Plan:
    ```
    make check
    # No good way to test this since I don't have a Windows dev machine.
    ```
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3203
  8. Merge #13052: trivial: Fix relevent typo

    MarcoFalke authored and jasonbcox committed Apr 23, 2018
    Summary:
    6ad47b0 trivial: Fix relevent typo (practicalswift)
    
    Pull request description:
    
      Fix relevent typo.
    
    Tree-SHA512: 29247a780ab2caf0180c3558632a00068b02b4de4a56825f425c66a1e515542ab1e5268971ffa9a63e46840504101b5e6a5f8dcb6070522ac3f5ca90a28262b9
    
    Backport of Core PR13052
    https://github.com/bitcoin/bitcoin/pull/13052/files
    
    Test Plan: `make check`
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3202
  9. Merge #12616: Set modal overlay hide button as default

    laanwj authored and jasonbcox committed Mar 6, 2018
    Summary:
    cfdd895 qt: Set modal overlay hide button as default (João Barbosa)
    
    Pull request description:
    
      Without this change the only way to close the modal overlay is to click the hide button. Setting the button to default allows to activate it with the ENTER key.
    
      Before:
      <img width="849" alt="screen shot 2018-03-06 at 15 14 23" src="https://user-images.githubusercontent.com/3534524/37040276-58af9ce0-2151-11e8-8c55-50acdea669d9.png">
    
      After:
      <img width="848" alt="screen shot 2018-03-06 at 15 12 41" src="https://user-images.githubusercontent.com/3534524/37040294-650d1c9c-2151-11e8-8245-2da250a71b3d.png">
    
    Tree-SHA512: a93ef440a507843ed7870fd07a693af93dd97c8fce2fb6824c69a227b5dee258f340bf1ae344da32a9dd6e6cb2330f72db9dac9635bbd34184c3e7f8476a472e
    
    Backport of Core PR12616
    bitcoin/bitcoin#12616
    
    Test Plan:
    ```
    make check
    bitcoin-qt
    # Hit Enter key once the progress modal appears. The modal should hide.
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3201
  10. Merge #12384: [Docs] Add version footnote to tor.md

    laanwj authored and jasonbcox committed May 1, 2018
    Summary:
    39d2911 [Docs] Add version footnote to tor.md (Damian Williamson)
    
    Pull request description:
    
      [Docs] Add version footnote to tor.md
    
      Added note to section 2, part -edits to `/etc/tor/torrc`- indicating this is only required for Tor version 0.2.7.0 and older, since section 3 states it is valid for Tor version 0.2.7.1 and newer. Added ref link from section 2 version footnote to section 3. Re-styled headings to work on GitHub -alternate heading style markup creation issue with numbered headings and thus headings and automatic heading links are broken-
    
      Ref: [Issue# 12376](bitcoin/bitcoin#12376)
    
      Signed-off-by: Damian Williamson \<willtech@live.com.au\>
    
    Tree-SHA512: 439f4ccc3e196011af448b220adf26b0e653ac589bf4cfbbc276c1500c9d08f209c9d6101e4d232857779d9f25164cfb222ed30e3d63de116f9121e6ebde31c3
    
    Backport of Core PR12384
    https://github.com/bitcoin/bitcoin/pull/12384/files
    
    Test Plan: Read it and verify against the original PR.
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3200
  11. Merge #10714: Avoid printing incorrect block indexing time due to uni…

    sipa authored and jasonbcox committed Jul 12, 2017
    …nitialized variable
    
    Summary:
    959dd87 Avoid printing incorrect block indexing time due to uninitialized variable (practicalswift)
    
    Tree-SHA512: a76e43c3ffa734ed5c7eadf363f345f268aa0e6ce775aba8f856fe3bbc82f240dc7c734c5ca3ac500a12eb41fae00623413e79f484d5acf809b6e400851d771d
    
    Backport of Core PR10714
    https://github.com/bitcoin/bitcoin/pull/10714/files
    
    Test Plan: `make check`
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3209
  12. Replace childs => children in radix.h

    Fabcien committed Jun 5, 2019
    Summary: As per title.
    
    Test Plan:
      ./src/test/test_bitcoin -t radix_tests
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3215
  13. [LINTER] Enforce using C++ headers instead of C compatible headers

    Fabcien committed Apr 17, 2019
    Summary:
    This linter replaces the C compatibility headers with the native C++
    ones.
    
    Note: it currently conflicts with clang-format (the fix gets erased).
    `arc lint` may need to be run multiple times to fix all the issues. A
    solution to these conflicts should be submitted later.
    
    Test Plan:
    Add the following line:
      #include <stddef.h>
    Immediatly after `#include <memory>` in `src/init.cpp`.
      arc lint
    The linter should return an error for the newly added line and propose
    the fix.
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3213
  14. Replace c compatibility header with native c++ header

    Fabcien committed Jun 5, 2019
    Summary: This is the last case in the codebase.
    
    Test Plan:
      make check
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3212
  15. Merge #11406: Add state message print to AcceptBlock failure message.

    laanwj authored and jasonbcox committed Oct 4, 2017
    Summary:
    6643b80 Add state message print to AcceptBlock failure message. (Matt Corallo)
    
    Pull request description:
    
      This should make it easier to debug issues where the CheckBlock at
      the top of ProcessNewBlock fails (which does not print, in contrast
      to AcceptBlock, which always prints).
    
      This was motivated by #11371 which appears to be exactly such a case, and is not debuggable from the information provided. Not sure how much this would have helped in that case, but it is kinda weird that we can reject a block without ever printing why.
    
    Tree-SHA512: 7a1c2c76080b810212da885c38e091609e409c62918cc326bb36a1096e09b2ae7e26fd4bdaefd79863d2894e2823e463005700a524940f177a59ef09f589b2f1
    
    Backport of Core PR11406
    https://github.com/bitcoin/bitcoin/pull/11406/files
    
    Test Plan:
    ```
    # on master
    test_runner.py --nocleanup
    
    grep -rni "acceptblock fail" /tmp/<bitcoin-temp-dir>
    # example error:
    ERROR: ProcessNewBlock: AcceptBlock FAILED
    
    # with this patch
    make check
    test_runner.py
    
    grep -rni "acceptblock fail" /tmp/<bitcoin-temp-dir>
    # example error:
    ERROR: ProcessNewBlock: AcceptBlock FAILED (Transaction order is invalid (01fc91cfedbea4a49c943158746de0467801cd24594139c8482ce976f3ed6101 < ce56a7306a2c9b1a6a7ecb8a31f17883023f3d224e1b09c2709ba8dca5dae53c))
    
    Reviewers: #bitcoin_abc, deadalnix
    
    Reviewed By: #bitcoin_abc, deadalnix
    
    Differential Revision: https://reviews.bitcoinabc.org/D3211
Older
You can’t perform that action at this time.