Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the build reproducible #233

Merged

Conversation

@lamby
Copy link
Contributor

lamby commented Oct 28, 2019

Whilst working on the Reproducible Builds effort we noticed that khard could not be built reproducibly.

This is because it includes the absolute build directory in the documentation via the SPEC_FILE attribute. This commit calculates this value dynamically instead.

(This was originally filed in Debian as #943471.)

khard/config.py Outdated Show resolved Hide resolved
khard/config.py Outdated Show resolved Hide resolved
Whilst working on the Reproducible Builds effort [0] we noticed that
khard could not be built reproducibly.

This is because it includes the absolute build directory in the
documentation via the SPEC_FILE attribute. This commit calculates
this value dynamically instead.

This was originally filed in Debian as #943471 [1].

 [0] https://reproducible-builds.org/
 [1] https://bugs.debian.org/943471
@lamby lamby force-pushed the lamby:943471-khard-please-make-the-build-reproducible branch from 35ba4a3 to 2290509 Oct 28, 2019
@lamby

This comment has been minimized.

Copy link
Contributor Author

lamby commented Oct 28, 2019

Thanks for the quick review; pushed updated commit..

@lucc
lucc approved these changes Oct 28, 2019
@lucc lucc merged commit 1b9e049 into scheibler:master Oct 28, 2019
@lucc

This comment has been minimized.

Copy link
Collaborator

lucc commented Oct 28, 2019

Thanks for you help @lamby !

@lamby lamby deleted the lamby:943471-khard-please-make-the-build-reproducible branch Oct 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.