Repeated branchCode property in Store #1073

Closed
Dataliberate opened this Issue Apr 4, 2016 · 1 comment

Projects

None yet

2 participants

@Dataliberate
Contributor

The branchCode property is repeated 3 times on the Store term page and twice on the LocalBusiness page.

Basic reason is that the property is unnecessarily defined as having a domainIncludes for Place, LocalBusiness, and Store. Place would be sufficient as it would be inherited by the others.

Need to fix definition and consider checks in the display code to prevent repeat display and possibly warn of the circumstance.

@danbri danbri pushed a commit that closed this issue Apr 6, 2016
Dan Brickley Removed redundant type associations on branchCode.
Fixes #1073
b11a59f
@danbri danbri closed this in b11a59f Apr 6, 2016
@danbri
Contributor
danbri commented Apr 6, 2016
@danbri danbri pushed a commit that referenced this issue Jun 17, 2016
Dan Brickley Commented out section deleted. See #1073.
Also #1203 as this was (falsely) suspected to be an accidental reversion.
e651d02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment