Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Repeated branchCode property in Store #1073

Closed
Dataliberate opened this issue Apr 4, 2016 · 1 comment
Closed

Repeated branchCode property in Store #1073

Dataliberate opened this issue Apr 4, 2016 · 1 comment

Comments

@Dataliberate
Copy link
Contributor

The branchCode property is repeated 3 times on the Store term page and twice on the LocalBusiness page.

Basic reason is that the property is unnecessarily defined as having a domainIncludes for Place, LocalBusiness, and Store. Place would be sufficient as it would be inherited by the others.

Need to fix definition and consider checks in the display code to prevent repeat display and possibly warn of the circumstance.
@danbri danbri closed this as completed in b11a59f Apr 6, 2016
@danbri
Copy link
Contributor

danbri commented Apr 6, 2016

Fixed, thanks @RichardWallis

Queued for next release,

danbri added a commit that referenced this issue Jun 17, 2016
@danbri
Commented out section deleted. See #1073.
e651d02 
Also #1203 as this was (falsely) suspected to be an accidental reversion.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danbri @Dataliberate