"manufacturer" dropped from Product ? #1158

Closed
radusi opened this Issue May 11, 2016 · 7 comments

Projects

None yet

4 participants

@radusi
radusi commented May 11, 2016

v2.2 has "manufacturer" Property for Product, while v3.0 hasn't [ in appears only for http://health-lifesci.schema.org/Product ]

@mfhepp
Contributor
mfhepp commented May 12, 2016

Thanks for spotting this, this needs to be fixed!!!

@twamarc
Contributor
twamarc commented May 13, 2016

This comes from med-health-core.rdfa (line 2239)
mistakenly by extending the domain of we ended up with:

<div typeof="rdf:Property" resource="http://schema.org/manufacturer">
  <span class="h" property="rdfs:label">manufacturer</span>
  <span property="rdfs:comment">The manufacturer of the product.</span>
  <link property="http://schema.org/isPartOf" href="http://health-lifesci.schema.org" />
  <span>Domain: <a property="http://schema.org/domainIncludes" href="http://schema.org/DietarySupplement">DietarySupplement</a></span>
  <span>Domain: <a property="http://schema.org/domainIncludes" href="http://schema.org/Drug">Drug</a></span>
  <span>Domain: <a property="http://schema.org/domainIncludes" href="http://schema.org/Product">Product</a></span>
  <span>Range: <a property="http://schema.org/rangeIncludes" href="http://schema.org/Organization">Organization</a></span>
</div>

I suggest to remove the line:
<link property="http://schema.org/isPartOf" href="http://health-lifesci.schema.org" />
If it's in the following shape, then it will be fixed:

<div typeof="rdf:Property" resource="http://schema.org/manufacturer">
  <span class="h" property="rdfs:label">manufacturer</span>
  <span property="rdfs:comment">The manufacturer of the product.</span>
  <span>Domain: <a property="http://schema.org/domainIncludes" href="http://schema.org/DietarySupplement">DietarySupplement</a></span>
  <span>Domain: <a property="http://schema.org/domainIncludes" href="http://schema.org/Drug">Drug</a></span>
  <span>Domain: <a property="http://schema.org/domainIncludes" href="http://schema.org/Product">Product</a></span>
  <span>Range: <a property="http://schema.org/rangeIncludes" href="http://schema.org/Organization">Organization</a></span>
</div> 

But please note that the 2 new types extended for domain remains in: health-lifesci.schema.org extension.

@RichardWallis : Are you going to fix this together with the bug fixing #1159 or I submit another pull request for that?

@danbri
Contributor
danbri commented May 13, 2016 edited

I will hot fix this between releases. But shouldn't it still show up in the extensions section of the page, @RichardWallis

@danbri
Contributor
danbri commented May 13, 2016

Ah I see it now

@mfhepp
Contributor
mfhepp commented May 13, 2016

thanks!

martin hepp http://www.heppnetz.de
mhepp@computer.org @mfhepp

On 13 May 2016, at 12:38, Dan Brickley notifications@github.com wrote:

I will hot fix this between releases. But shouldn't it still show up in the extensions section of the page, @richardwalli

โ€”
You are receiving this because you commented.
Reply to this email directly or view it on GitHub

@danbri danbri pushed a commit that referenced this issue May 15, 2016
Dan Brickley Linked #1158 b891ad3
@danbri
Contributor
danbri commented May 15, 2016

Ok, http://schema.org/docs/releases.html should show the fix now.

@danbri
Contributor
danbri commented Aug 12, 2016

Confirming that this is still fixed - see http://schema.org/manufacturer - I'll close the issue. Thanks @radusi et al.

@danbri danbri closed this Aug 12, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment