New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfix needed for errors in health-lifesci and pending Course definitions #1169

Closed
danbri opened this Issue May 20, 2016 · 0 comments

Comments

Projects
None yet
1 participant
@danbri
Contributor

danbri commented May 20, 2016

Thanks to #1168 we can belatedly catch some bugs in extension definitions. These are in the health-lifesci definitions (/cc @twamarc) and the pending draft for courses (/cc @philbarker #195), and the health-related pending proposal #1062 for ushealthcare descriptions (/cc @vholland).

I will simply comment out all the corresponding domain/range assertions for now, except for Url -> URL.

I note for courses we ought to talk about whether 'credential' and 'certificate' work well as names; to a broader tech audience they could look like crypto terminology rather than educational.

1.)
test_validDomainIncludes (test_graphs.SDOGraphSetupTestCase) ...

1a.
INFO:test_graphs:Property http://schema.org/bodyLocation invalid domainIncludes value: http://schema.org/MedicalSpecimen

1b.
INFO:test_graphs:Property http://schema.org/drugUnit invalid domainIncludes value: http://schema.org/DrugDispense

FAIL

2.)
test_validRangeIncludes (test_graphs.SDOGraphSetupTestCase) ...
2a.
INFO:test_graphs:Property http://schema.org/benefitsSummaryUrl invalid rangeIncludes value: http://schema.org/Url
2b.
INFO:test_graphs:Property http://schema.org/grantsCredential invalid rangeIncludes value: http://schema.org/Credential
2c.
INFO:test_graphs:Property http://schema.org/healthPlanMarketingUrl invalid rangeIncludes value: http://schema.org/Url

FAIL

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment